[feat](query_v2) Add PrefixQuery, PhrasePrefixQuery and UnionPostings support #60701
Open
zzzxl1993 wants to merge 1 commit intoapache:masterfrom
Open
[feat](query_v2) Add PrefixQuery, PhrasePrefixQuery and UnionPostings support #60701zzzxl1993 wants to merge 1 commit intoapache:masterfrom
zzzxl1993 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 29932 ms |
TPC-DS: Total hot run time: 190898 ms |
ClickBench: Total hot run time: 28.51 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 30923 ms |
TPC-DS: Total hot run time: 188542 ms |
ClickBench: Total hot run time: 28.34 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
zzzxl1993
force-pushed
the
202602121310
branch
from
75af3e8 to
b3d60df
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 28990 ms |
TPC-DS: Total hot run time: 185779 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
airborne12
reviewed
Feb 13, 2026
| } | ||
|
|
||
| auto bit_set = std::make_shared<BitSetScorer>(doc_bitset); | ||
| auto const_score = std::make_shared<ConstScoreScorer<BitSetScorerPtr>>(std::move(bit_set)); |
Member
There was a problem hiding this comment.
why use ConstScoreScorer here, not supported scoring?
Contributor
Author
There was a problem hiding this comment.
Prefix queries don't support scoring in the traditional sense. They expand to multiple terms (e.g., "pre" matches "prefix", "prepare", "present", etc.), and scoring each expanded term individually doesn't make semantic sense - the user is searching for a prefix pattern, not independent terms. That's why I use ConstScoreScorer to give all matching documents the same constant score. This is standard for prefix/fuzzy/wildcard queries.
airborne12
reviewed
Feb 13, 2026
| } | ||
| } | ||
|
|
||
| uint32_t advance() override { |
Member
There was a problem hiding this comment.
Adding a priority-queue (min-heap) optimization for advance()？
Contributor
Author
There was a problem hiding this comment.
I considered using a priority queue. Based on our dataset testing, the current linear scan performs well for typical query patterns. The simplicity and cache-friendly nature of linear scan outweigh the theoretical O(log n) advantage of heaps in practice. If profiling shows this becomes a bottleneck in the future, we can optimize with a hybrid approach (e.g., use heap when n > threshold).
airborne12
reviewed
Feb 13, 2026
| } | ||
|
|
||
| // Only prefix term, no phrase terms — fall back to a plain prefix query. | ||
| PrefixQuery prefix_query(_context, std::move(_field), std::move(_prefix.value().second)); |
Contributor
Author
There was a problem hiding this comment.
The std::move is intentional here - both code paths in weight() (line 59 and line 80) consume these members and return immediately, so the object won't be used after this call. This avoids unnecessary copies of the string data. But I can change to copy if you think it's clearer.
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)