refactor: remove config package dependency from health and reflectionservices#3197
refactor: remove config package dependency from health and reflectionservices#3197CAICAIIs wants to merge 1 commit intoapache:developfrom
Conversation
… services Remove dependencies on config package from: - protocol/triple/health/healthServer.go - protocol/triple/reflection/serverreflection.go Both services already register via server.SetProviderServices() in init(), so config.SetProviderServiceWithInfo() calls are no longer needed. Relates to apache#2741 Signed-off-by: Sisyphus <sisyphus@apache.org>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3197 +/- ##
===========================================
+ Coverage 46.76% 47.81% +1.04%
===========================================
Files 295 461 +166
Lines 17172 33440 +16268
===========================================
+ Hits 8031 15988 +7957
- Misses 8287 16176 +7889
- Partials 854 1276 +422 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes the config package dependency from the built-in Triple health check and server reflection services by deleting legacy config.SetProviderServiceWithInfo() registrations, relying solely on server.SetProviderServices() internal-service registration.
Changes:
- Remove
dubbo.apache.org/dubbo-go/v3/configimport from health and reflection internal services. - Remove
config.SetProviderServiceWithInfo()calls previously used for legacyconfig.Loadcompatibility.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| protocol/triple/reflection/serverreflection.go | Drops config import and removes provider-service registration into config maps for reflection. |
| protocol/triple/health/healthServer.go | Drops config import and removes provider-service registration into config maps for health. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.



Remove dependencies on config package from:
Both services already register via server.SetProviderServices() in init(), so config.SetProviderServiceWithInfo() calls are no longer needed.
config.SetProviderServiceWithInfo():
Description
Related to #2741
Checklist
develop