FINERACT-2177: Add Git signed commits verification#5431
Open
DeathGun44 wants to merge 1 commit intoapache:developfrom
Open
FINERACT-2177: Add Git signed commits verification#5431DeathGun44 wants to merge 1 commit intoapache:developfrom
DeathGun44 wants to merge 1 commit intoapache:developfrom
Conversation
meonkeys
requested changes
Feb 3, 2026
CONTRIBUTING.md
Outdated
Comment on lines
280
to
288
| 1. Install GPG: | ||
| - **Mac**: `brew install gnupg` | ||
| - **Linux (Debian/Ubuntu)**: `sudo apt-get install gnupg` | ||
| - **Windows**: Download and install [Gpg4win](https://www.gpg4win.org/) | ||
| 2. Generate a key: `gpg --full-generate-key` | ||
| - Select `(1) RSA and RSA` | ||
| - Key size: `4096` | ||
| - Expiration: `0` (no expiration) | ||
| - Enter your name and GitHub email |
Contributor
There was a problem hiding this comment.
Please instead augment/update and refer to https://fineract.apache.org/docs/current/#_gpg_2. That's a more up to date key generation guide using elliptic curve encryption instead of RSA.
503c784 to
25807d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses FINERACT-2177 by adding a workflow to enforce Git Commit Signing.
The Implementation
scripts/verify-signed-commits.sh. This ensures the check can be run locally by any developer (./scripts/verify-signed-commits.sh) and is CI-agnostic.Ustatus) while correctly flagging unsigned commits (N).::error) to highlight specific problematic commits in the PR file view.This PR includes the
--strictflag, which will fail the build for unsigned commits.--strictflag for the initial merge to allow a grace period.Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!