[FLINK-38839][runtime] Support semicolon delimiter for table-options#4199
Open
tchivs wants to merge 2 commits intoapache:masterfrom
Open
[FLINK-38839][runtime] Support semicolon delimiter for table-options#4199tchivs wants to merge 2 commits intoapache:masterfrom
tchivs wants to merge 2 commits intoapache:masterfrom
Conversation
leonardBang
reviewed
Dec 26, 2025
.../src/main/java/org/apache/flink/cdc/runtime/operators/transform/SchemaMetadataTransform.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the suggestion @leonardBang! I've updated the PR to support custom delimiters as you recommended. Changes made:
Example usage: transform:
- source-table: mydb.mytable
table-options: sequence.field=gxsj,jjsj;file-index.bloom-filter.columns=jjdbh
table-options.delimiter: ";"This approach is more flexible and powerful as users can now choose any delimiter that suits their needs. |
This commit extends the table-options feature to support custom delimiters, making it more flexible and powerful for users. Changes: - Add optional 'table-options.delimiter' configuration parameter - Default delimiter is ',' for backward compatibility - Support any custom delimiter (e.g., ';', '|', '$', etc.) - Update TransformDef, SchemaMetadataTransform, and TransformRule classes - Update YAML parser to handle the new configuration - Add test cases for custom delimiter functionality - Update documentation with usage examples Example usage: transform: - source-table: mydb.mytable table-options: sequence.field=gxsj,jjsj;file-index.bloom-filter.columns=jjdbh table-options.delimiter: ";"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
table-optionsin transform rules to use semicolon;as the key/value pair delimiter so option values can safely contain commas (e.g.sequence.field=gxsj,jjsj). Keep comma delimiter for backward compatibility.Motivation
Some downstream table options are multi-value and use comma inside the value. The existing
key1=value1,key2=value2syntax makes those options impossible to express reliably.Changes
SchemaMetadataTransformparsestable-optionspairs using:;when present in the string, otherwise,split("=", 2)to avoid breaking values containing=Behavior
table-options: key1=value1,key2=value2table-options: sequence.field=gxsj,jjsj;file-index.range-bitmap.columns=jjsj;file-index.bloom-filter.columns=jjdbh;(do not mix,and;in the same string).