[GOBBLIN-2160] Setup Temporal docker Cluster for CI Tests and added tests for AbstractNestingExecWorkflowImpl #4059
Open
pratapaditya04 wants to merge 7 commits intoapache:masterfrom
Open
Conversation
d81af91 to
a75214d
Compare
a75214d to
3950d10
Compare
khandelwal-prateek
suggested changes
Sep 24, 2024
.../java/org/apache/gobblin/temporal/util/nesting/workflow/AbstractNestingExecWorkflowImpl.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/gobblin/temporal/ddm/workflow/impl/AbstractNestingExecWorkflowImplTest.java
Show resolved
Hide resolved
.../java/org/apache/gobblin/temporal/ddm/workflow/impl/AbstractNestingExecWorkflowImplTest.java
Outdated
Show resolved
Hide resolved
added 6 commits
October 7, 2024 20:24
… temporal_module_unit_tests # Conflicts: # gobblin-temporal/build.gradle
Blazer-007
reviewed
Nov 12, 2024
Comment on lines
+52
to
+54
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(AbstractNestingExecWorkflowImplTest.class); | ||
|
|
Member
There was a problem hiding this comment.
I don't think we need to log / or print something in tests, can we please remove them ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Added Unit tests for JobStateUtils and AbstractNestingExecWorkflowImpl classes in Gobblin-temporal module
Tests
Commits