GUACAMOLE-2185: Port numbers should be validated by guacd.

[bbennett-ks]

• Tested RDP, SSH, Telnet , and VNC using valid and invalid port numbers and verifying DEBUG logs.

[necouchman]

Overall I'm okay with it. Just a few comments.

The only other concern I have is if there's any potential impact to ABI or API compatibility since this changes the type of several of those settings members from int to unsigned short? We generally try not to break compatibility in minor version releases like this, so I just want to make sure that doesn't bite us (or, more importantly, our users).

[bbennett-ks]

Overall I'm okay with it. Just a few comments.

The only other concern I have is if there's any potential impact to ABI or API compatibility since this changes the type of several of those settings members from int to unsigned short? We generally try not to break compatibility in minor version releases like this, so I just want to make sure that doesn't bite us (or, more importantly, our users).

It should be OK based on how it is used, but I'll revert those changes as they are unnecessary and adds risk.

[bbennett-ks]

Overall I'm okay with it. Just a few comments.
The only other concern I have is if there's any potential impact to ABI or API compatibility since this changes the type of several of those settings members from int to unsigned short? We generally try not to break compatibility in minor version releases like this, so I just want to make sure that doesn't bite us (or, more importantly, our users).

It should be OK based on how it is used, but I'll revert those changes as they are unnecessary and adds risk.

On second thought, the core fix that changes an out of range port value (doesn't fit inside an unsigned short) to the default value changes the ABI/API compatibility. So, changing the underlying data type doesn't introduce any additional functional impact. So if it's OK, I'll leave the changes.

[necouchman]

A couple of additional changes, and I think there are still a couple of past items to be finished up.

[bbennett-ks]

A couple of additional changes, and I think there are still a couple of past items to be finished up.

Please let me know if I need to make any additional changes. Thanks!

[necouchman]

@bbennett-ks Looks like the build is failing - maybe a missing include in the K8s protocol:

#20 19.45 settings.c: In function 'guac_kubernetes_parse_args':
#20 19.45 settings.c:283:57: error: 'GUAC_ITOA_USHORT_MIN' undeclared (first use in this function)
#20 19.45   283 |                 IDX_PORT, GUAC_KUBERNETES_DEFAULT_PORT, GUAC_ITOA_USHORT_MIN, GUAC_ITOA_USHORT_MAX);
#20 19.45       |                                                         ^~~~~~~~~~~~~~~~~~~~
#20 19.45 settings.c:283:57: note: each undeclared identifier is reported only once for each function it appears in
#20 19.51 settings.c:283:79: error: 'GUAC_ITOA_USHORT_MAX' undeclared (first use in this function)
#20 19.51   283 |                 IDX_PORT, GUAC_KUBERNETES_DEFAULT_PORT, GUAC_ITOA_USHORT_MIN, GUAC_ITOA_USHORT_MAX);
#20 19.51       |                                                                               ^~~~~~~~~~~~~~~~~~~~

[bbennett-ks]

@bbennett-ks Looks like the build is failing - maybe a missing include in the K8s protocol:

#20 19.45 settings.c: In function 'guac_kubernetes_parse_args':
#20 19.45 settings.c:283:57: error: 'GUAC_ITOA_USHORT_MIN' undeclared (first use in this function)
#20 19.45   283 |                 IDX_PORT, GUAC_KUBERNETES_DEFAULT_PORT, GUAC_ITOA_USHORT_MIN, GUAC_ITOA_USHORT_MAX);
#20 19.45       |                                                         ^~~~~~~~~~~~~~~~~~~~
#20 19.45 settings.c:283:57: note: each undeclared identifier is reported only once for each function it appears in
#20 19.51 settings.c:283:79: error: 'GUAC_ITOA_USHORT_MAX' undeclared (first use in this function)
#20 19.51   283 |                 IDX_PORT, GUAC_KUBERNETES_DEFAULT_PORT, GUAC_ITOA_USHORT_MIN, GUAC_ITOA_USHORT_MAX);
#20 19.51       |                                                                               ^~~~~~~~~~~~~~~~~~~~

Ah, libwebsockets-devel wasn't installed on my new dev VM so Kubernetes support wasn't enabled. Verified all protocols were enabled.