Spark Test: Fix flaky TestCopyOnWriteDelete tests#15227
Draft
gabeiglio wants to merge 2 commits intoapache:mainfrom
Draft
Spark Test: Fix flaky TestCopyOnWriteDelete tests#15227gabeiglio wants to merge 2 commits intoapache:mainfrom
gabeiglio wants to merge 2 commits intoapache:mainfrom
Conversation
gabeiglio
force-pushed
the
fix-flaky-test
branch
from
5ac62f9 to
944e529
Compare
gabeiglio
force-pushed
the
fix-flaky-test
branch
from
944e529 to
1e7b4f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These test were timing out on our CI builds, doing some investigation this exact issue came out in a similar test, and applying the same fix worked
The test was also getting stuck locally when running:
./gradlew --stacktrace -Pquick=true -x javadoc :iceberg-spark:iceberg-spark-extensions-4.0_2.13:test -DscalaVersion=2.13 -DsparkVersions=4.0 \ --tests "org.apache.iceberg.spark.extensions.TestCopyOnWriteDelete"Note: I only saw this in spark 4.0, but seems harmless to backport it to all other versions