feat(go): implement Go leader redirection scenario#2580
Open
chengxilo wants to merge 6 commits intoapache:masterfrom
Open
feat(go): implement Go leader redirection scenario#2580chengxilo wants to merge 6 commits intoapache:masterfrom
chengxilo wants to merge 6 commits intoapache:masterfrom
Conversation
hubcio
approved these changes
Jan 30, 2026
hubcio
reviewed
Jan 30, 2026
Contributor
hubcio
left a comment
There was a problem hiding this comment.
Trying to find someone to review it.
hubcio
requested changes
Feb 3, 2026
| return false, nil | ||
| } | ||
|
|
||
| func (c *IggyTcpClient) LoginWithPersonalAccessToken(token string) (*iggcon.IdentityInfo, error) { |
Contributor
There was a problem hiding this comment.
LoginUser has leader redirection logic, but LoginWithPersonalAccessToken does not
| return err | ||
| } | ||
|
|
||
| m.Nodes = make([]ClusterNode, 0, nodesCount) |
Contributor
There was a problem hiding this comment.
malformed packet with nodesCount = 0xFFFFFFFF would attempt to allocate memory for 4 billion slots, limit it to max 10 nodes or so
| c.mtx.Unlock() | ||
|
|
||
| if err = c.disconnect(); err != nil { | ||
| return false, err |
Contributor
There was a problem hiding this comment.
if disconnect fails after IncrementRedirect() was called, the redirect counter remains incremented but no redirection actually occurred.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go leader redirection scenario implement
What I did
TransportEndpointsimplementMarshalBinary/UnmarshalBinary(implementencoding.BinaryMarshaler/encoding.Unmarshalerinterface) instead of create a function likeSerializeTransportEndpoints/DeserializeEndpoints. We may replace the previous approach later.Notes
iggyclimust update toclientDeserializeXXX/SerializeXXXwith implmentingMarshalBinary/UnmarshalBinaryin the future.