[VL][Iceberg] Fix input_file_name() on Iceberg, JNI init stability, and metadata propagation#11615
Open
ReemaAlzaid wants to merge 1 commit intoapache:mainfrom
Open
[VL][Iceberg] Fix input_file_name() on Iceberg, JNI init stability, and metadata propagation#11615ReemaAlzaid wants to merge 1 commit intoapache:mainfrom
ReemaAlzaid wants to merge 1 commit intoapache:mainfrom
Conversation
…initialization for Velox
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
Here are the relevant test cases I ran BeforeAfter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR fixes
input_file_name(),input_file_block_start(),input_file_block_length()behavior on Iceberg with Velox and addresses a related JNI crash path.Issue: #11513
Main fixes
JNI stability fix (Velox native path)
cpp/core/jni/JniCommon.hSparkAllocationListenerconstructor.getMethodIdOrErrorto avoid unsafe JNI method lookup failures.Iceberg split metadata propagation fix
cpp/velox/compute/WholeStageResultIterator.ccHiveIcebergSplit(instead of empty metadata), so file metadata is preserved.Iceberg metadata wiring
gluten-iceberg/src/main/scala/org/apache/iceberg/spark/source/GlutenIcebergSourceUtil.scalagluten-iceberg/src/main/java/org/apache/gluten/substrait/rel/IcebergLocalFilesBuilder.javagluten-iceberg/src/main/java/org/apache/gluten/substrait/rel/IcebergLocalFilesNode.javainput_file_nameinput_file_block_startinput_file_block_lengthScan transformer + rule generalization
gluten-substrait/src/main/scala/org/apache/gluten/execution/BatchScanExecTransformer.scalagluten-iceberg/src/main/scala/org/apache/gluten/execution/IcebergScanTransformer.scalagluten-kafka/src/main/scala/org/apache/gluten/execution/MicroBatchScanExecTransformer.scalagluten-paimon/src-paimon/main/scala/org/apache/gluten/execution/PaimonScanTransformer.scalawithOutput(...)forBatchScanExecTransformerBasefamily.PushDownInputFileExpressionto work againstBatchScanExecTransformerBaseand deduplicaterewriteExpr.How was this patch tested?
mvn -o -Pgluten-substrait,gluten-iceberg -DskipTests compileinput_file_name(),input_file_block_start(),input_file_block_length()and reproduction with Gluten Velox bundle