[GLUTEN-11402][VL] Fix decimal partition key serialization to preserve scale#11618
Open
acvictor wants to merge 1 commit intoapache:mainfrom
Open
[GLUTEN-11402][VL] Fix decimal partition key serialization to preserve scale#11618acvictor wants to merge 1 commit intoapache:mainfrom
acvictor wants to merge 1 commit intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
acvictor
force-pushed
the
acvictor/decimalPartition
branch
from
8d961b0 to
d0172fa
Compare
|
Run Gluten Clickhouse CI on x86 |
acvictor
force-pushed
the
acvictor/decimalPartition
branch
from
d0172fa to
f97d6e1
Compare
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
@baibaichen @zhouyuan can you please review? Thanks! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR fixes decimal partition value serialization by replacing
toJavaBigInteger.toStringwithtoJavaBigDecimal.unscaledValue().toString, removes fallback guard that was added by #11518 and adds additional test cases to SQLQuerySuite covering small decimals, zero-scale decimals, negative values, and multi-partition pruning.How was this patch tested?
Extended the existing
Incorrect decimal casting for partition readtestWas this patch authored or co-authored using generative AI tooling?
No
Related issue: #11402