OAK-12077 : added joinUninterruptibly() in oak-commons#2711
Merged
rishabhdaim merged 4 commits intotrunkfrom Jan 30, 2026
Merged
OAK-12077 : added joinUninterruptibly() in oak-commons#2711rishabhdaim merged 4 commits intotrunkfrom
rishabhdaim merged 4 commits intotrunkfrom
Conversation
mbaedke
reviewed
Jan 29, 2026
| UninterruptibleUtils.joinUninterruptibly(worker); | ||
| long elapsedMillis = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - start); | ||
|
|
||
| // Worker may still be alive (likely), but we at least checked the timeout behavior |
Contributor
There was a problem hiding this comment.
I don't understand. The whole point of join() is to wait until the thread terminates. How would it still be alive after join() returns?
mbaedke
reviewed
Jan 29, 2026
| @Test | ||
| public void testJoinShouldWaitUntilThreadFinishes() { | ||
| final Thread worker = new Thread(() -> { | ||
| // Run longer than the join timeout |
reschke
reviewed
Jan 29, 2026
| boolean interrupted = false; | ||
|
|
||
| try { | ||
| for(;;) { |
Contributor
Author
There was a problem hiding this comment.
They are same, even at the machine code level.
mbaedke
reviewed
Jan 29, 2026
...est/java/org/apache/jackrabbit/oak/commons/internal/concurrent/UninterruptibleUtilsTest.java
Show resolved
Hide resolved
mbaedke
reviewed
Jan 29, 2026
|
|
||
| // Interrupt the joining thread multiple times while it is waiting | ||
| for (int i = 0; i < 3; i++) { | ||
| Thread.sleep(50L); |
Contributor
There was a problem hiding this comment.
Same as above, too late to interrupt.
|
mbaedke
approved these changes
Jan 30, 2026
reschke
pushed a commit
that referenced
this pull request
Feb 4, 2026
* OAK-12077 : added joinUninterruptibly() in oak-commons * OAK-12077 : added review comments * OAK-12077 : updated sleep durations to sleep within joining period * OAK-12077 : fixed assertion errors if occured in joiningThread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.