Draft
Conversation
c3a88b9 to
33f1a03
Compare
33f1a03 to
f1520d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved (TDB)
This is a long standing revision of the service enhancer module. It can go into a dot release after jena 6. There are a couple of places that seem odd to me and which I want to give another look.
Pull request Description:
Code maintenance:
RequestExecutorto support read-transaction-aware concurrent execution.Bug Fixes:
ja:datasetproperty instead of the customja:baseDataset. Use of the latter still works but now raises a warning.SERVICE <https://.../foo:>becameSERVICE <https://.../foo>)SELECT ... LIMIT Xwhere X was slightly larger than the maximum cache size.New Features:
scopedoption for loop (SERVICE <loop+scoped:>) to mimic the behavior of LATERAL - whenscopedis set, then only in-scope variables become substituted instead of all variables with the same base name.ServiceConcurrentExample. Essentially, it allows one to doSERVICE <loop+scoped:concurrent+2-10:bulk+10:cache:https://example.org/sparql>: Use 2 additional threads with 10 bindings each, to build bulk requests of 10 bindings, caching the responses to query the specified sparql endpoint. Concurrent requests try to preserve the order of bindings. Of course, one must be cautious not to flood public endpoints. The feature is intended as a tool to improve query federation performance over endpoints that one controls.By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.