feat: allow expressions for TestElement.enabled property#6478
Open
vlsi wants to merge 2 commits intoapache:masterfrom
Open
feat: allow expressions for TestElement.enabled property#6478vlsi wants to merge 2 commits intoapache:masterfrom
vlsi wants to merge 2 commits intoapache:masterfrom
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a proof-of-concept implementation for conditional
TestElement.enabled.The downside is that
isEnabled()call would be added for every sampler, listener, pre-processor, pos-processor, and so on which might slow down the execution.Motivation and Context
See #6006
How Has This Been Tested?
See
EnabledWithVariablesTestScreenshots (if appropriate):
WIP:

Checklist:
..RequestDefaults. The logic ofmerge...Elementprobably needs ignoring disabled elementsinterface JMeterGUIComponentneeds to support expressions. Currently there'sboolean getEnabled()andsetEnabled(boolean)jmeter/src/core/src/main/java/org/apache/jmeter/gui/tree/JMeterTreeModel.java
Lines 169 to 175 in 91ed127