Add curl examples to operator-http-api#255
Open
nhandler wants to merge 1 commit intoapache:masterfrom
Open
Conversation
When reading this document, many people will want to test out the requests against their own environment. Providing curl examples will help assist with this task.
Contributor
|
@nhandler Thanks for doing this! Awesome. Do I take it that you tested all these commands? Also, is the EOF required in all the curl commands? |
Contributor
|
@nhandler similar to Vinod's comment: I think we could probably get away without the heredoc notation, to get rid of the EOFs? i.e.: This works when I test it in bash anyway :) |
Contributor
|
@nhandler If you can update the PR, I'll commit it ASAP. |
Contributor
|
@nhandler we were reviewing PRs today and came across this one - do you have a cycle to update real quick? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading this document, many people will want to test out the
requests against their own environment. Providing curl examples will
help assist with this task.