Open
Conversation
enterprise/glassfish.eecommon/src/org/netbeans/modules/glassfish/eecommon/api/DomainEditor.java
Outdated
Show resolved
Hide resolved
enterprise/glassfish.eecommon/src/org/netbeans/modules/glassfish/eecommon/api/DomainEditor.java
Outdated
Show resolved
Hide resolved
enterprise/glassfish.eecommon/src/org/netbeans/modules/glassfish/eecommon/api/DomainEditor.java
Outdated
Show resolved
Hide resolved
...ise/payara.micro/src/org/netbeans/modules/fish/payara/micro/project/DeployOnSaveManager.java
Outdated
Show resolved
Hide resolved
BradWalker
force-pushed
the
cleanup_map_raw_type
branch
3 times, most recently
from
8b62fa5 to
2135e4c
Compare
Cleanup May raw type warnings that look like this: [repeat] /home/bwalker/src/netbeans/ide/team.commons/src/org/netbeans/modules/bugtracking/commons/AttachmentsPanel.java:353: warning: [rawtypes] found raw type: Map [repeat] Map attributes = cmp.getFont().getAttributes(); [repeat] ^ [repeat] missing type arguments for generic class Map<K,V> [repeat] where K,V are type-variables: [repeat] K extends Object declared in interface Map [repeat] V extends Object declared in interface Map Also, some minor code cleanup.
BradWalker
force-pushed
the
cleanup_map_raw_type
branch
from
2135e4c to
7424845
Compare
Member
Author
|
Need to resolve this old PR.. So I rebased against the latest, resolved the comments, and it's now ready. |
mbien
reviewed
Dec 30, 2025
Comment on lines
260
to
+263
| /** | ||
| * @return Map{@code <String, String>} containing vendor specific properties. | ||
| */ | ||
| public abstract Map getUnresolvedVendorSpecificProperties(); | ||
| public abstract Map<String, String> getUnresolvedVendorSpecificProperties(); |
Member
There was a problem hiding this comment.
the implementations should be also updated, otherwise it becomes an unchecked conversion warning there
Comment on lines
1125
to
1131
| private Map dtdMap; | ||
| private Map<String, String> dtdMap; | ||
| private ResourceElem topRE; | ||
| private StringBuffer pcdata = new StringBuffer(); | ||
| private int weight; | ||
| private String uri; | ||
|
|
||
| Handler(Map dtdMap, ResourceElem rootElem, boolean validate) { |
Member
There was a problem hiding this comment.
@matthiasblaesing Handler is package private and I don't see the constructor in the sig file. I suppose this means package private inner classes aren't exported?
constructor could be changed to:
Handler(Map<String, String> dtdMap, ResourceElem rootElem, boolean validate) {the now redundant cast in L1277 should be now also removed
String publicURL = (String) dtdMap.get(pid);
->
String publicURL = dtdMap.get(pid);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup May raw type warnings that look like this:
[repeat] /home/bwalker/src/netbeans/ide/team.commons/src/org/netbeans/modules/bugtracking/commons/AttachmentsPanel.java:353: warning: [rawtypes] found raw type: Map
[repeat] Map attributes = cmp.getFont().getAttributes();
[repeat] ^
[repeat] missing type arguments for generic class Map<K,V>
[repeat] where K,V are type-variables:
[repeat] K extends Object declared in interface Map
[repeat] V extends Object declared in interface Map
Also, some minor code cleanup.
^Add meaningful description above
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.