Properly resolving types in ChangeMethodParameters refactoring.#8637
Open
lahodaj wants to merge 1 commit intoapache:masterfrom
Open
Properly resolving types in ChangeMethodParameters refactoring.#8637lahodaj wants to merge 1 commit intoapache:masterfrom
lahodaj wants to merge 1 commit intoapache:masterfrom
Conversation
shivam71
added a commit
to shivam71/javavscode
that referenced
this pull request
Aug 18, 2025
Minor change in the original patch line 76 '-spec.version.base=1.91.0' changed to '-spec.version.base=1.89.0' the above change require as our netbeans 25 currently was on refactoring api version 1.89.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider code like:
put cursor at
JavaApplication113.test, open theRefactor/Change Method Parameters, and add a new parameter with typejava.util.List<java.lang.String>and namepar1. The refactoring will usejava.util.List<java.lang.String>as the parameter type that is written in the source code. I think imports should be properly resolved on every place where the type is printed, and typicallyjava.util.Listshould be imported, and the inserted type should beList<String>.This is what this PR is attempting to do.