Skip to content

EL: improve resourcebundles handling#9177

Draft
NicolaIsotta wants to merge 3 commits intoapache:masterfrom
NicolaIsotta:el-bundles
Draft

EL: improve resourcebundles handling#9177
NicolaIsotta wants to merge 3 commits intoapache:masterfrom
NicolaIsotta:el-bundles

Conversation

@NicolaIsotta
Copy link
Contributor

This is a follow-up to #8603
The main aim is enabling CTRL + Hover and CTRL + click on ResourceBundle items in JSF pages:
image
image
The features were already integrated in ELHyperlinkProvider but it seems GsfHyperlinkProvider has the precedence so I had to implement them in ELDeclarationFinder (which is called by GsfHyperlinkProvider).
Aside from that, I tried to improve the resource bundled loading here and there, using the built-in cache whenever possible.


Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@mbien mbien added enterprise [ci] enable enterprise job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jan 30, 2026
@mbien mbien added this to the NB30 milestone Jan 30, 2026
@apache apache locked and limited conversation to collaborators Jan 30, 2026
@apache apache unlocked this conversation Jan 30, 2026
@NicolaIsotta NicolaIsotta marked this pull request as draft February 2, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) enterprise [ci] enable enterprise job

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants