Enhance behaviour of showing Favorites on first editor usage#9186
Open
neilcsmith-net wants to merge 2 commits intoapache:deliveryfrom
Open
Enhance behaviour of showing Favorites on first editor usage#9186neilcsmith-net wants to merge 2 commits intoapache:deliveryfrom
neilcsmith-net wants to merge 2 commits intoapache:deliveryfrom
Conversation
neilcsmith-net
added
Editor
Platform
Member
|
improvements look good to me on first glance. I agree that we could try to get this in for NB 29. The fact that it opens with the dashboard (since it uses the editor mode) is indeed annoying and the introduction of |
Use TopComponent.Registry and only open Favorites on first open of a file editing component. Do not open for non-file TopComponents like Dashboard.
neilcsmith-net
force-pushed
the
gh8908rev
branch
from
9537759 to
0aef505
Compare
mbien
approved these changes
Feb 4, 2026
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #8908
A further enhancement might be to do the equivalent of calling
Tab::doSelectNodebut without taking focus away from the opening editor?Could possible target delivery, but it's a minor usage fix so left for NB30 for now.