Remove redundant params from defn bodies#1408
Draft
mdedetrich wants to merge 2 commits intoapache:mainfrom
Draft
Remove redundant params from defn bodies#1408mdedetrich wants to merge 2 commits intoapache:mainfrom
mdedetrich wants to merge 2 commits intoapache:mainfrom
Conversation
mdedetrich
pushed a commit
to mdedetrich/pekko
that referenced
this pull request
Jul 21, 2024
mdedetrich
force-pushed
the
remove-redundant-params-from-defn-bodies
branch
from
f6453f8 to
3db058b
Compare
mdedetrich
pushed a commit
to mdedetrich/pekko
that referenced
this pull request
Jul 21, 2024
mdedetrich
force-pushed
the
remove-redundant-params-from-defn-bodies
branch
from
3db058b to
5eb0aee
Compare
Contributor
Author
|
Seems like there is a bug in scalafmt, reported upstream at scalameta/scalafmt#4108 |
He-Pin
reviewed
Jul 22, 2024
| } finally { | ||
| } finally | ||
| context.clearCurrentActorThread() | ||
| } |
mdedetrich
pushed a commit
to mdedetrich/pekko
that referenced
this pull request
Sep 16, 2024
Signed-off-by: Matthew de Detrich <mdedetrich@gmail.com> # Conflicts: # actor-typed-tests/src/test/scala/org/apache/pekko/actor/typed/SupervisionSpec.scala # cluster-sharding/src/main/scala/org/apache/pekko/cluster/sharding/ClusterSharding.scala # stream/src/main/scala/org/apache/pekko/stream/javadsl/SourceWithContext.scala
mdedetrich
force-pushed
the
remove-redundant-params-from-defn-bodies
branch
from
5eb0aee to
68e2102
Compare
mdedetrich
force-pushed
the
remove-redundant-params-from-defn-bodies
branch
from
68e2102 to
c839a2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the codebase has a lot of cases of redundant/useless braces, this scalafmt configuration removes all of these braces.
When this gets merged In a future PR I will add this commit to
.git-blame-ignore-revs