feat!: upgrade project's Node version to v22#37223
Conversation
Signed-off-by: hainenber <dotronghai96@gmail.com>
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
github-actions
bot
added
doc
dosubot
bot
added
the
risk:breaking-change
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
CodeAnt AI finished reviewing your PR. |
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #aa8f23
Actionable Suggestions - 1
-
superset-websocket/.nvmrc - 1
- Version Mismatch · Line 1-1
Review Details
-
Files reviewed - 5 · Commit Range:
e6031a6..e6031a6- docs/.nvmrc
- superset-embedded-sdk/.nvmrc
- superset-frontend/.nvmrc
- superset-websocket/.nvmrc
- superset-websocket/utils/client-ws-app/.nvmrc
-
Files skipped - 2
- superset-frontend/package-lock.json - Reason: Filter setting
- superset-frontend/package.json - Reason: Filter setting
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
| @@ -1 +1 @@ | |||
| v20.18.3 | |||
| v22.22.0 | |||
There was a problem hiding this comment.
The .nvmrc specifies Node.js v22.22.0, but the package.json engines require '^20.19.4', creating an inconsistency that could cause issues with package managers or CI if engines are enforced.
Code Review Run #aa8f23
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
There was a problem hiding this comment.
@hainenber I do remember having to update this in a few random places last time I did it (a long time ago!)
There was a problem hiding this comment.
I wonder if there's some good way to centralize all of this to make it easier.
There was a problem hiding this comment.
Yes, to centralize Node.js version management in this monorepo, consider placing a single .nvmrc at the root. This lets all subprojects inherit the version. Alternatively, use Volta by adding a 'volta' field in the root package.json specifying the node version.
.nvmrc
v22.22.0
There was a problem hiding this comment.
We can have a centralized .nvmrc in root dir /superset and sym-link this particular file to other sub-projects. Wdyt?
There was a problem hiding this comment.
Centralizing the .nvmrc at the root and sym-linking to sub-projects is a solid idea—it reduces duplication and simplifies updates across the monorepo. Just ensure sym-links are handled properly in CI/CD and version control to avoid issues.
2 participants
feat!: upgrade project's Node version to v22
SUMMARY
Node 20 is about to EoL in upcoming 3 months so IMO, we should proactively bump to next LTS, which is 22. There aren't any noticeable breaking changes between these LTS versions so I'd say we're pretty good to go
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Green CI for acceptance criterion
ADDITIONAL INFORMATION