Skip to content

fix(helm): Add default initContainer resources#37637

Open
retrry wants to merge 1 commit intoapache:masterfrom
retrry:chore/initcontainer-resources
Open

fix(helm): Add default initContainer resources#37637
retrry wants to merge 1 commit intoapache:masterfrom
retrry:chore/initcontainer-resources

Conversation

@retrry
Copy link

@retrry retrry commented Feb 3, 2026

SUMMARY

Some Kubernetes clusters enforce policies that require all containers, including initContainers, to define resource requests and/or limits. The Superset Helm chart currently omits resource definitions for its initContainers, which can cause installations to fail in such environments unless users fully override the initContainers in their values.yaml. This change adds conservative default resource requests and limits to the built-in initContainers across Superset components, improving out-of-the-box compatibility while keeping behavior unchanged and remaining fully configurable.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Feb 3, 2026

Code Review Agent Run #1cfffd

Actionable Suggestions - 0
Additional Suggestions - 1
  • helm/superset/Chart.yaml - 1
    • Documentation Inconsistency · Line 32-32
      The README.md version badge still shows 0.15.2, but Chart.yaml has been updated to 0.15.3. Since the README is generated by helm-docs, it should be regenerated to reflect the new version.
      Code suggestion
       @@ -25,1 +25,1 @@
      -![Version: 0.15.2](https://img.shields.io/badge/Version-0.15.2-informational?style=flat-square)
      +![Version: 0.15.3](https://img.shields.io/badge/Version-0.15.3-informational?style=flat-square)
Review Details
  • Files reviewed - 3 · Commit Range: b19dfaa..b19dfaa
    • bleh
    • helm/superset/Chart.yaml
    • helm/superset/values.yaml
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added the deploy:helm label Feb 3, 2026
@retrry retrry force-pushed the chore/initcontainer-resources branch from b19dfaa to 06f78b1 Compare February 3, 2026 09:22
@pull-request-size pull-request-size bot added size/M and removed size/L labels Feb 3, 2026
@retrry retrry force-pushed the chore/initcontainer-resources branch from 06f78b1 to 5893c32 Compare February 3, 2026 09:33
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Feb 3, 2026

Code Review Agent Run #07862f

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: 5893c32..5893c32
    • helm/superset/Chart.yaml
    • helm/superset/values.yaml
  • Files skipped - 1
    • helm/superset/README.md - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants