THRIFT-5564: Add Python to GitHub Actions cross-test matrix #3298
+616
−283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Python (py) to the cross-language test matrix. Python was never included in the GitHub Actions cross-test despite being part of the original migration plan. Changes: - Add precross step to lib-python job (for Python 3.12) - Upload Python precross artifacts (lib, gen-py, test scripts) - Download Python artifacts in cross-test job - Add 'py' to server_lang and client_lang matrix - Install Python test dependencies in cross-test job - Add 582 known failures based on actual CI results - Remove 279 stale py3 entries (never validated in GitHub Actions) Known failure categories added: - cpp-py: 54 SSL failures - go-py: 18 SSL failures - java-py: 72 SSL failures - py-cpp: 162 protocol incompatibilities - py-go: 48 protocol incompatibilities - py-java: 171 protocol incompatibilities - py-kotlin: 5 SSL failures - py-py: 72 SSL failures - py-rs: 40 protocol incompatibilities
mergeable
bot
added
the
github_actions
Contributor
Author
|
@fishy I'm working on a larger cleanup of Python EOL versions but I thought it might be nice to get the Python cross-test working so we can track progress as we fix some of the issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Python (py) to the cross-language test matrix. Python was never included in the GitHub Actions cross-test despite being part of the original migration plan (THRIFT-5564). Dropped the separate py3 branch, as we only support python 3 now. Hopefully we can remove some of these known failures in future PRs.
Related issues:
Changes
Add Python to cross-test matrix
Add 582 known failures based on actual CI results:
Remove 279 stale py3 entries - The py3 test suite was removed and these entries were never validated in GitHub Actions CI.
Test plan