TINKERPOP-2992 Fixed orderability bug on OffsetDateTime #3303
Conversation
| | bar | | ||
| | foo | | ||
| | zzz | | ||
| | uuid[5100808b-62f9-42b7-957e-ed66c30f40d1] | |
There was a problem hiding this comment.
Nit: It doesn't look like UUID is mentioned in the gremlin-semantics orderability section so it's not immediately obvious if this is where it belongs. Would be best to add clarification in the documentation.
| * <li>Makes enums explicit with their proper name</li> | ||
| * </ul> | ||
| * <p/> | ||
| * Assumes use of https://www.npmjs.com/package/uuid library for UUID handling. |
There was a problem hiding this comment.
I think we are trying to avoid using npm packages for JavaScript types as it can stop the GLV from being used in the browser.
There was a problem hiding this comment.
we were already committed to using uuid though: https://github.com/apache/tinkerpop/blob/3.8.0/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/language/translator/JavascriptTranslateVisitor.java#L222
all i did was use the parse mechanism for a defined uuid. i suppose we could remove the translation wholly? but then a part of Gremlin doesn't work which now has a uuid() function.
|
VOTE +1, pending nits. I only did a quick overview of the gremlin-go section as I don't really know that language well, would be great is someone else could review that section more closely. |
Fixed javascript translator for uuid. Added testing on date, set, uuid.
spmallette
force-pushed
the
TINKERPOP-2992
branch
from
abed92a to
54cbdc4
Compare
2 participants
https://issues.apache.org/jira/browse/TINKERPOP-2992
Fixed javascript translator for uuid. Added testing on date, set, uuid.
VOTE +1