Change the method name "make" to "getNameId".#66
Open
ShangwenWang wants to merge 1 commit intoapache:mainfrom
Open
Change the method name "make" to "getNameId".#66ShangwenWang wants to merge 1 commit intoapache:mainfrom
ShangwenWang wants to merge 1 commit intoapache:mainfrom
Conversation
Simulant87
reviewed
Dec 10, 2021
|
|
||
| /** | ||
| * Set default precedence according to the parent FObj | ||
| * |
There was a problem hiding this comment.
Suggested change
| * | |
| * @deprecated Use {@link #getNameId(PropertyList)} instead |
|
I am out of the office until 13-12-2021.
Please contact InfoSuite support at ***@***.*** for assistance.
Note: This is an automated response to your message "Re: [apache/xmlgraphics-fop] Change the method name "make" to "getNameId". (#66)"( sent on 10-12-2021 20:54:07) .
This is the only notification you will receive while this person is away.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method seems to find a "Property" related to the fo.getNameId().
Hence, the new name "getNameId" should be better than "make".