ZOOKEEPER-4988: Add [-R] recursive option to getAcl cli command#2334
ZOOKEEPER-4988: Add [-R] recursive option to getAcl cli command#2334anmolnar wants to merge 2 commits intoapache:masterfrom
Conversation
| out.println(path1); | ||
| printAcl(zk.getACL(path1, stat), stat); |
There was a problem hiding this comment.
Rather than print on separate lines, it would be better if these were formatted such that they could be on one line, so the output can be more easily parsed by somebody redirecting this elsewhere. Could the path be appended with something like # /path/to/node?
There was a problem hiding this comment.
Makes sense to me, let me take a look.
|
|
||
| static { | ||
| options.addOption("s", false, "stats"); | ||
| options.addOption("R", false, "recursive"); |
There was a problem hiding this comment.
Why upper-case? Was lower-case already used? I guess it doesn't matter, but I'm curious.
|
|
||
| public GetAclCommand() { | ||
| super("getAcl", "[-s] path"); | ||
| super("getAcl", "[-s] [-R] path"); |
There was a problem hiding this comment.
I think commons-cli, which it looks like ZK is using, can generate help documentation automatically. It shouldn't be necessary to maintain a description that is passed around. But, that's out of scope of this PR. I was just surprised to see a help document being manually updated in this PR.
2 participants
No description provided.