Add config option to always show suggestion list#73
Open
kamerc wants to merge 4 commits intoapasccon:developfrom
kamerc:master
Open
Add config option to always show suggestion list#73kamerc wants to merge 4 commits intoapasccon:developfrom kamerc:master
kamerc wants to merge 4 commits intoapasccon:developfrom
kamerc:master
Conversation
|
Yeap , have same prorblem |
# Conflicts: # SearchTextField/Classes/SearchTextField.swift
Author
|
@apasccon any update on getting this pull request merged in? I just merged in your latest changes into my repo so there are no longer any conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature is useful if we are doing the actual filtering we need via a REST service and we want to show all the results it returns. If the exact text matches, the highlight will continue to be displayed. This is useful if the user is searching for values that may exist in metadata but not always displayed on the title or subtitle.