-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(annotations): avoid rect drift when zoom != 100% #5159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
junedchhipa
merged 1 commit into
apexcharts:main
from
meronz:issue/fix-annotations-zoom
Feb 11, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
144 changes: 144 additions & 0 deletions
144
samples/source/line/line-with-annotations-zoom-level.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| <title>Line Chart with Annotations (Zoom Level)</title> | ||
|
|
||
| <style> | ||
| #chart { | ||
| max-width: 650px; | ||
| margin: 35px auto; | ||
| } | ||
| #chart-zoom-wrapper { | ||
| zoom: 80%; | ||
| } | ||
| </style> | ||
|
|
||
| <html> | ||
| <div id="chart-zoom-wrapper"> | ||
| {{ charts[0] }} | ||
| </div> | ||
| </html> | ||
|
|
||
| <scripts> | ||
| <script src="../../assets/stock-prices.js"></script> | ||
| </scripts> | ||
|
|
||
| <chart> | ||
| <options> | ||
| chart: { | ||
| height: 350, | ||
| type: 'line', | ||
| id: 'areachart-2' | ||
| }, | ||
| annotations: { | ||
| yaxis: [{ | ||
| y: 8200, | ||
| borderColor: '#00E396', | ||
| label: { | ||
| borderColor: '#00E396', | ||
| style: { | ||
| color: '#fff', | ||
| background: '#00E396', | ||
| }, | ||
| text: 'Support', | ||
| } | ||
| }, { | ||
| y: 8600, | ||
| y2: 9000, | ||
| borderColor: '#000', | ||
| fillColor: '#FEB019', | ||
| opacity: 0.2, | ||
| label: { | ||
| borderColor: '#333', | ||
| style: { | ||
| fontSize: '10px', | ||
| color: '#333', | ||
| background: '#FEB019', | ||
| }, | ||
| text: 'Y-axis range', | ||
| } | ||
| }], | ||
| xaxis: [{ | ||
| x: new Date('23 Nov 2017').getTime(), | ||
| strokeDashArray: 0, | ||
| borderColor: '#775DD0', | ||
| label: { | ||
| borderColor: '#775DD0', | ||
| style: { | ||
| color: '#fff', | ||
| background: '#775DD0', | ||
| }, | ||
| text: 'Anno Test', | ||
| } | ||
| }, { | ||
| x: new Date('26 Nov 2017').getTime(), | ||
| x2: new Date('28 Nov 2017').getTime(), | ||
| fillColor: '#B3F7CA', | ||
| opacity: 0.4, | ||
| label: { | ||
| borderColor: '#B3F7CA', | ||
| style: { | ||
| fontSize: '10px', | ||
| color: '#fff', | ||
| background: '#00E396', | ||
| }, | ||
| offsetY: -10, | ||
| text: 'X-axis range', | ||
| } | ||
| }], | ||
| points: [{ | ||
| x: new Date('01 Dec 2017').getTime(), | ||
| y: 8607.55, | ||
| marker: { | ||
| size: 8, | ||
| fillColor: '#fff', | ||
| strokeColor: 'red', | ||
| radius: 2, | ||
| cssClass: 'apexcharts-custom-class' | ||
| }, | ||
| label: { | ||
| borderColor: '#FF4560', | ||
| offsetY: 0, | ||
| style: { | ||
| color: '#fff', | ||
| background: '#FF4560', | ||
| }, | ||
|
|
||
| text: 'Point Annotation', | ||
| } | ||
| }, { | ||
| x: new Date('08 Dec 2017').getTime(), | ||
| y: 9340.85, | ||
| marker: { | ||
| size: 0 | ||
| }, | ||
| image: { | ||
| path: '../../assets/images/ico-instagram.png' | ||
| } | ||
| }] | ||
| }, | ||
| dataLabels: { | ||
| enabled: false | ||
| }, | ||
| stroke: { | ||
| curve: 'straight' | ||
| }, | ||
| grid: { | ||
| padding: { | ||
| right: 30, | ||
| left: 20 | ||
| } | ||
| }, | ||
| title: { | ||
| text: 'Line with Annotations', | ||
| align: 'left' | ||
| }, | ||
| labels: series.monthDataSeries1.dates, | ||
| xaxis: { | ||
| type: 'datetime', | ||
| }, | ||
| </options> | ||
|
|
||
| <series> | ||
| [{ | ||
| data: series.monthDataSeries1.prices | ||
| }] | ||
| </series> | ||
| </chart> |
188 changes: 188 additions & 0 deletions
188
samples/vanilla-js/line/line-with-annotations-zoom-level.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,188 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <meta http-equiv="X-UA-Compatible" content="ie=edge" /> | ||
| <title>Line Chart with Annotations (Zoom Level)</title> | ||
|
|
||
| <link href="../../assets/styles.css" rel="stylesheet" /> | ||
|
|
||
| <style> | ||
|
|
||
| #chart { | ||
| max-width: 650px; | ||
| margin: 35px auto; | ||
| } | ||
| #chart-zoom-wrapper { | ||
| zoom: 80%; | ||
| } | ||
|
|
||
| </style> | ||
|
|
||
| <script> | ||
| window.Promise || | ||
| document.write( | ||
| '<script src="https://cdn.jsdelivr.net/npm/promise-polyfill@8/dist/polyfill.min.js"><\/script>' | ||
| ) | ||
| window.Promise || | ||
| document.write( | ||
| '<script src="https://cdn.jsdelivr.net/npm/eligrey-classlist-js-polyfill@1.2.20171210/classList.min.js"><\/script>' | ||
| ) | ||
| window.Promise || | ||
| document.write( | ||
| '<script src="https://cdn.jsdelivr.net/npm/findindex_polyfill_mdn"><\/script>' | ||
| ) | ||
| </script> | ||
|
|
||
|
|
||
| <script src="../../../dist/apexcharts.js"></script> | ||
|
|
||
|
|
||
| <script> | ||
| // Replace Math.random() with a pseudo-random number generator to get reproducible results in e2e tests | ||
| // Based on https://gist.github.com/blixt/f17b47c62508be59987b | ||
| var _seed = 42; | ||
| Math.random = function() { | ||
| _seed = _seed * 16807 % 2147483647; | ||
| return (_seed - 1) / 2147483646; | ||
| }; | ||
| </script> | ||
|
|
||
| <script src="../../assets/stock-prices.js"></script> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div id="chart-zoom-wrapper"> | ||
| <div id="chart"></div> | ||
| </div> | ||
|
|
||
| <script> | ||
|
|
||
| var options = { | ||
| series: [{ | ||
| data: series.monthDataSeries1.prices | ||
| }], | ||
| chart: { | ||
| height: 350, | ||
| type: 'line', | ||
| id: 'areachart-2' | ||
| }, | ||
| annotations: { | ||
| yaxis: [{ | ||
| y: 8200, | ||
| borderColor: '#00E396', | ||
| label: { | ||
| borderColor: '#00E396', | ||
| style: { | ||
| color: '#fff', | ||
| background: '#00E396', | ||
| }, | ||
| text: 'Support', | ||
| } | ||
| }, { | ||
| y: 8600, | ||
| y2: 9000, | ||
| borderColor: '#000', | ||
| fillColor: '#FEB019', | ||
| opacity: 0.2, | ||
| label: { | ||
| borderColor: '#333', | ||
| style: { | ||
| fontSize: '10px', | ||
| color: '#333', | ||
| background: '#FEB019', | ||
| }, | ||
| text: 'Y-axis range', | ||
| } | ||
| }], | ||
| xaxis: [{ | ||
| x: new Date('23 Nov 2017').getTime(), | ||
| strokeDashArray: 0, | ||
| borderColor: '#775DD0', | ||
| label: { | ||
| borderColor: '#775DD0', | ||
| style: { | ||
| color: '#fff', | ||
| background: '#775DD0', | ||
| }, | ||
| text: 'Anno Test', | ||
| } | ||
| }, { | ||
| x: new Date('26 Nov 2017').getTime(), | ||
| x2: new Date('28 Nov 2017').getTime(), | ||
| fillColor: '#B3F7CA', | ||
| opacity: 0.4, | ||
| label: { | ||
| borderColor: '#B3F7CA', | ||
| style: { | ||
| fontSize: '10px', | ||
| color: '#fff', | ||
| background: '#00E396', | ||
| }, | ||
| offsetY: -10, | ||
| text: 'X-axis range', | ||
| } | ||
| }], | ||
| points: [{ | ||
| x: new Date('01 Dec 2017').getTime(), | ||
| y: 8607.55, | ||
| marker: { | ||
| size: 8, | ||
| fillColor: '#fff', | ||
| strokeColor: 'red', | ||
| radius: 2, | ||
| cssClass: 'apexcharts-custom-class' | ||
| }, | ||
| label: { | ||
| borderColor: '#FF4560', | ||
| offsetY: 0, | ||
| style: { | ||
| color: '#fff', | ||
| background: '#FF4560', | ||
| }, | ||
|
|
||
| text: 'Point Annotation', | ||
| } | ||
| }, { | ||
| x: new Date('08 Dec 2017').getTime(), | ||
| y: 9340.85, | ||
| marker: { | ||
| size: 0 | ||
| }, | ||
| image: { | ||
| path: '../../assets/images/ico-instagram.png' | ||
| } | ||
| }] | ||
| }, | ||
| dataLabels: { | ||
| enabled: false | ||
| }, | ||
| stroke: { | ||
| curve: 'straight' | ||
| }, | ||
| grid: { | ||
| padding: { | ||
| right: 30, | ||
| left: 20 | ||
| } | ||
| }, | ||
| title: { | ||
| text: 'Line with Annotations', | ||
| align: 'left' | ||
| }, | ||
| labels: series.monthDataSeries1.dates, | ||
| xaxis: { | ||
| type: 'datetime', | ||
| }, | ||
| }; | ||
|
|
||
| var chart = new ApexCharts(document.querySelector("#chart"), options); | ||
| chart.render(); | ||
|
|
||
|
|
||
| </script> | ||
|
|
||
|
|
||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const zoom = elGridRect.width / gridBBox.width || 1does not guard againstgridBBox.width === 0. In that case the expression becomesInfinity, and subsequent divisions byzoomcollapse coordinates/sizes toward 0. Use an explicit zero-check (and consider checking both width/height if you want extra safety) so zoom reliably falls back to1when the BBox is degenerate.