Skip to content

Conversation

@itssimon
Copy link
Member

@itssimon itssimon commented Jan 22, 2026

Summary by CodeRabbit

  • Chores
    • Implemented consistent code formatting and style rules across the project
    • Updated continuous integration workflows to support multi-version .NET testing with improved build verification
    • Configured repository-wide line ending standards for cross-platform consistency

✏️ Tip: You can customize this high-level summary in your review settings.

@itssimon itssimon self-assigned this Jan 22, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

This PR establishes project-wide code style standards through .editorconfig and .gitattributes, migrates the CI pipeline from Python-based pre-commit hooks to .NET-based GitHub Actions workflows with multi-version testing, updates workflow permissions, and removes the pre-commit configuration file.

Changes

Cohort / File(s) Summary
Code Style Configuration
.editorconfig, .gitattributes
Introduces global indent and line-ending standards (4-space indent globally, 2-space for specific file types, LF line endings); Makefile uses tab indentation
Workflow Permission & Formatting Updates
.github/workflows/publish.yaml, .github/workflows/summary.yaml
Adds id-token: write and contents: read permissions to publish workflow; adds blank line formatting to both workflows
CI Pipeline Migration
.github/workflows/tests.yaml
Replaces Python pre-commit check with .NET-based setup; renames job to check; adds dotnet tool restore and csharpier formatting checks; expands test job to cover .NET versions 6.0.x through 9.0.x with code coverage and codecov upload
Pre-commit Configuration Removal
.pre-commit-config.yaml
Removes entire pre-commit hook configuration including Python hooks, dotnet-tool-restore, and csharpier checks
Project File Reformatting
tests/Apitally.Tests/Apitally.Tests.csproj
Whitespace and line-order adjustments; no functional changes to properties or dependencies

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-pre-commit

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.57%. Comparing base (b95e520) to head (6e6346b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   84.73%   84.57%   -0.17%     
==========================================
  Files          23       23              
  Lines        1873     1873              
  Branches      169      169              
==========================================
- Hits         1587     1584       -3     
- Misses        232      235       +3     
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@itssimon itssimon merged commit 4eb8676 into main Jan 22, 2026
4 of 5 checks passed
@itssimon itssimon deleted the remove-pre-commit branch January 22, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant