Skip to content

feat: Add runtime flag to container create and run commands (#1049)#1109

Open
iko1 wants to merge 2 commits intoapple:mainfrom
iko1:feature/runtime-flag
Open

feat: Add runtime flag to container create and run commands (#1049)#1109
iko1 wants to merge 2 commits intoapple:mainfrom
iko1:feature/runtime-flag

Conversation

@iko1
Copy link
Contributor

@iko1 iko1 commented Jan 29, 2026

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

Fixes #1049

  • Add --runtime option for Flags.Management
  • Apply runtime handler in containerConfigFromFlags
  • Update command-reference.md doc

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

Copy link
Contributor

@jglogan jglogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iko1 Is there a use case for exposing this flag?

I'd think we'd want to expose it once another runtime helper exists somewhere, and that that helper needs to be invoked explicitly via a flag like this.

@iko1
Copy link
Contributor Author

iko1 commented Feb 2, 2026

@iko1 Is there a use case for exposing this flag?

I'd think we'd want to expose it once another runtime helper exists somewhere, and that that helper needs to be invoked explicitly via a flag like this.

@jglogan , thanks for the review

If @katiewasnothere has a concrete use case for exposing it, I’m happy to update the PR accordingly; otherwise I’ll go ahead and close this and revisit when such a use case comes up.

@iko1 iko1 closed this Feb 3, 2026
@jglogan
Copy link
Contributor

jglogan commented Feb 5, 2026

@iko1 I'll check with @katiewasnothere

@katiewasnothere
Copy link
Contributor

@iko1 Hi! One example use case for this would be if someone wanted to make a FreeBSD runtime plugin for container (see this open issue) or a runc runtime plugin. It would be nice for us to be able to start and manage those containers through the same CLI commands as opposed to needing a CLI plugin to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: Support requesting runtime types in container commands

3 participants