CLI: Forego logging errors on multi-container operations#1163
Merged
dcantah merged 1 commit intoapple:mainfrom Feb 5, 2026
Merged
CLI: Forego logging errors on multi-container operations#1163dcantah merged 1 commit intoapple:mainfrom
dcantah merged 1 commit intoapple:mainfrom
Conversation
Instead of logging errors, and then additionally throwing an error stating what containers couldn't be stopped/killed/deleted, lets just concatenate the errors and throw the single error.
jglogan
approved these changes
Feb 5, 2026
Contributor
jglogan
left a comment
jglogan
left a comment
There was a problem hiding this comment.
Approved but see comment.
| @@ -0,0 +1,32 @@ | |||
| //===----------------------------------------------------------------------===// | |||
Contributor
There was a problem hiding this comment.
Would we ever have to deal with aggregate errors below the command level? If so, would this be better defined along with container-specific error types in ContainerResource?
Member
Author
There was a problem hiding this comment.
For now I don't see much use, it's mostly a cli presentation helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of logging errors, and then additionally throwing an error stating what containers couldn't be stopped/killed/deleted, let's just concatenate the errors and throw the single error.