Fix image size calculation to show unpacked size#991
Open
Bortnyak wants to merge 11 commits intoapple:mainfrom
Open
Fix image size calculation to show unpacked size#991Bortnyak wants to merge 11 commits intoapple:mainfrom
Bortnyak wants to merge 11 commits intoapple:mainfrom
Conversation
Contributor
Author
|
Hey @dcantah, take a look at this PR please. |
Contributor
Author
Contributor
Author
Contributor
|
@Bortnyak I'll try to review it next week. Thanks for the reminder, and sorry for the delay! Could you rebase it PR to resolve the conflicts? |
Bortnyak
force-pushed
the
fix-image-size
branch
from
6c979b4 to
50eccb4
Compare
Contributor
Author
|
Thanks @jglogan. |
Contributor
|
@Bortnyak Sorry, still owe this a review, I haven’t forgotten |
7 tasks
jglogan
reviewed
Jan 27, 2026
|
|
||
| let created = config.created ?? "" | ||
| let size = descriptor.size + manifest.config.size + manifest.layers.reduce(0, { (l, r) in l + r.size }) | ||
| let compressedSize = descriptor.size + manifest.config.size + manifest.layers.reduce(0, { (l, r) in l + r.size }) |
Contributor
There was a problem hiding this comment.
See the implementation in #862, if that moves into the image client and we merge that, you could use the same logic for the OCI image size, and then you could extend it so it instead returns a struct containing say, ociImageSize and snapshotSize.
Contributor
Author
There was a problem hiding this comment.
Thanks to both of you. I'll wait until #1098 is merged and will use that logic
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
#709
Previously,
container image list -vonly showed compressed blob size. Now it shows:Snapshot size (unpacked) when available
Compressed blob size as fallback when image hasn't been run yet
This better reflects actual storage usage and matches Docker's behavior of showing unpacked size.
Tests use >= comparisons because filesystems allocate space in fixed blocks (4KB on macOS), making exact byte counts unreliable.
Testing
p.s.: if this doesn't match with the maintainers' vision of how image size should be represented, feel free to close this PR :)