fix(dns): improve DNS server reliability and compatibility#998
Open
swiftveteran wants to merge 1 commit intoapple:mainfrom
Open
fix(dns): improve DNS server reliability and compatibility#998swiftveteran wants to merge 1 commit intoapple:mainfrom
swiftveteran wants to merge 1 commit intoapple:mainfrom
Conversation
…apple#696, apple#834) - Bind DNS server to network gateway addresses instead of only localhost - Detect stale nameserver after network migration and refresh resolvers - Add --dns-tcp flag to force TCP DNS queries for unreliable networks - Inherit host search domains for Tailscale/VPN compatibility
jglogan
reviewed
Jan 6, 2026
| } | ||
|
|
||
| /// Returns the host system's DNS search domains from /etc/resolv.conf. | ||
| public static func getHostSearchDomains() -> [String] { |
Contributor
There was a problem hiding this comment.
What's in /etc/resolv.conf isn't necessarily going to reflect the actual DNS configuration of the system.
You can see this in resolv.conf itself:
% more /etc/resolv.conf
#
# macOS Notice
#
# This file is not consulted for DNS hostname resolution, address
# resolution, or the DNS query routing mechanism used by most
# processes on this system.
#
# To view the DNS configuration used by this system, use:
# scutil --dns
#
# SEE ALSO
# dns-sd(1), scutil(8)
#
# This file is automatically generated.
#
search apple.com
nameserver <redacted>
nameserver <redacted>
Contributor
|
It looks like this change is going to make it so that we'll have a listener for our scoped DNS service on port 2053 on each network gateway. Who will actually send requests to these listeners? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #817, #696, #834
Type of Change
Motivation and Context
The DNS server now binds to network gateway addresses instead of only localhost, allowing containers to resolve hostnames correctly across different network configurations. This also fixes stale nameserver detection after network migration by refreshing resolvers when the network changes. A new --dns-tcp flag forces TCP for DNS queries on unreliable networks, and host search domains are now inherited for compatibility with Tailscale and other VPN configurations.
Testing