-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Delete multitenant and metacluster features #12583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 97 commits
Commits
Show all changes
102 commits
Select commit
Hold shift + click to select a range
867c259
remove some unneeded tests, and remove mentions of deleted tests from…
gxglass 4b0ef4e
Initiate removal of metacluster. NOTE: this seems to also want remova…
gxglass e55d4e0
Merge remote-tracking branch 'upstream/main' into delete2
gxglass 8aecd26
work on removing metacluster
gxglass 9d1e521
Merge remote-tracking branch 'upstream/main' into delete2
gxglass 7fbbbb6
Merge remote-tracking branch 'upstream/main' into delete2
gxglass e6f1b96
Merge remote-tracking branch 'upstream/main' into delete2
gxglass 608f640
delete files with `Tenant` in the name, having reviewed them to ensur…
gxglass a1158f6
fdb_c.h: remove prototypes for C API methods which have been deleted …
gxglass ff49685
Surgical removal of tenant references from files in bindings/ top lev…
gxglass 7ae16f6
Surgical removal of tenant related stuff from fdbcli/ top level direc…
gxglass 86ddbe9
Misc tenant code removal, and other stuff which I think may not be ne…
gxglass c444da6
Remove more tenant or tenant-adjacent or blob-granule-adjacent stuff.…
gxglass 4b84545
Start removing Tenant stuff from fdbclient/. Far from complete. Com…
gxglass ec46042
Remove tenant references from many source files. There are still abo…
gxglass 6ca080c
Merge remote-tracking branch 'upstream/main' into delete2
gxglass ee705f5
Remove tenant entanglement from watch functionality
gxglass e6936f9
Remove tenant stuff from fdbserver/tester.actor.cpp
gxglass 0ad2831
Delete metacluster workloads
gxglass 8741c4e
Remove tenant related stuff from workloads. Also taken the liberty o…
gxglass 265c4e8
Checkpoint tenant removal from FuzzApiCorrectness.actor.cpp
gxglass 2229798
NativeAPI.actor.cpp: `Tenant` has left the building.
gxglass 1d63faa
SimulatedCluster.actor.cpp: `Tenant` has left the building
gxglass ca1ec97
DDShardTracker.actor.cpp: Tenant evicted
gxglass eaaff24
storageserver.actor.cpp: `tenant` has left the building.
gxglass 381c36a
fdbserver/workloads/FuzzApiCorrectness.actor.cpp: remove tenant refer…
gxglass 38d9cb8
FileBackupAgent.actor.cpp: tenant has left the building
gxglass 692c357
CommitProxyServer.actor.cpp: remove tenant
gxglass 11e93f8
Remove more tenant references from misc files such as bindings tests,…
gxglass f333b83
Fix missing-file errors in CMakeLists.txt files. This is the first a…
gxglass 922cdea
checkpoint misc changes to fix compile errors
gxglass ab780df
checkpoint more compile fixes
gxglass dd5657e
StorageServerInterface.h: put back more verify() calls
gxglass 06ee4c1
More misc compile fixes
gxglass 2ec1951
whole bunch of misc fixups including some code put-backs to address c…
gxglass cb9afcb
More compile fixes
gxglass 04930c4
More compile fixes. Still does not compile.
gxglass e05c05b
incremental compile fixing
gxglass a20e854
...
gxglass f06c42f
...
gxglass 34757b3
Checkpoint a bunch of compile fixes. Not quite there but getting closer
gxglass 43ff16f
More compile fixes. There seem to be about 10 files left, mainly Com…
gxglass 648331d
IT COMPILES NOW. THIS IS STILL ALL UNTESTED. Unsurprisingly, Commit…
gxglass ec12376
Put back one block relating to encryption at rest mode. Simplify som…
gxglass aa54783
Put back some encryption related knobs
gxglass a6135d7
remove `enable_tenants` from local_cluster.py to maybe fix some ctests
gxglass e50ce56
Remove tenant related options from toml files.
gxglass e47490d
feature-status.md: add a line for encryption at rest, which seems to …
gxglass 112fc52
Fix a pretty bad bug introduced in tenant deletion; ensure we dont at…
gxglass 7c8585a
workloads/FuzzApiCorrectness.actor.cpp: avoid division by zero
gxglass 77d1243
flow/Platform.actor.cpp: add a try/catch wrapper around side threads;…
gxglass 1b14df6
NativeAPI.actor.cpp: fix a bug introduced in tenant removal relating …
gxglass 3eef30a
ReportConflictingKeys.actor.cpp: separate an ANDed assert into two as…
gxglass 2a9e9f0
SpecialKeySPaceCorrectness.actor.cpp: put back some logic removed wit…
gxglass 24d3e58
remove QuotaCommand.actor.cpp
gxglass f933fdb
Force disable tenant and encryption on disk in upgrade tests
gxglass c75a6f0
Merge remote-tracking branch 'upstream/main' into delete2
gxglass a8fae2f
Add back file I guess I deleted? who knows
gxglass d8b7c79
put back another file
gxglass b82b118
design/feature-status.md: update the new row for encryption at rest t…
gxglass 899be8d
Remove EncryptKeyProxyTest since we do not use it
gxglass 1f666ed
new file tests/slow/BulkDumpingS3WithChaos.toml: remove tenantModes s…
gxglass 7b38856
Merge remote-tracking branch 'upstream/main' into delete2
gxglass b9dad8c
Undo damage to pushToBackupMutations() from removing tenant feature. …
gxglass 40d6b9f
tests/restarting/from_7.4.0/Snap*-1: ensure that tenantModes = disabled
gxglass 6f7634e
Try again on workloads/FuzzApiCorrectness.actor.cpp
gxglass 2c386ab
simplify tenant-free (mostly) FuzzApiCorrectness workload code
gxglass 5a9ddb5
try harder to remove lingering tenant-related brokenness from FuzzApi…
gxglass f2c15d2
Explicitly specify tenantModes = ['disabled'] in all the -1 restart f…
gxglass 8b059ba
Remove tenantModes from 7.1-based upgrade tests as its an unknown opt…
gxglass 5809e7e
do not specify tenantModes in downgrade tests
gxglass 4b0ca79
Downgrade test to_7.4.5: dont say tenantModes
gxglass f08b0f2
more tenantModes updates
gxglass 329a3ff
Remove a legacy allowDefaultTenant that no longer is meaningful in do…
gxglass 5a47d93
Put back empty Optional<TenantName> turdlets into serialized log even…
gxglass 7d71a5c
disable encryption on a few more upgrade related test cases. That fe…
gxglass 103545b
Remove unneeded workload files that have been subject to #if 0 for a …
gxglass 34feb1d
disable encryption in more upgrade tests
gxglass 584ea4a
Remove choice four-letter words from commentary
gxglass b0074f8
Format 42 files
gxglass 5cffd4b
Merge remote-tracking branch 'upstream/main' into delete2
gxglass 9de095d
Try to fix a doc bug failing the CI build
gxglass dfbb65b
More doc compilation error fixes
gxglass fdf6ced
Delete more tenant junk from documentation
gxglass 1f2cdc7
fix spelling mistake in comment
gxglass 8153bf0
Remove deleted cross-references from documentation. This necessitate…
gxglass 3915730
Remove more tenant stuff from bindings tests
gxglass 17ab4da
Remove more tenant bits from design/ files
gxglass e517121
Remove more tenant related stuff
gxglass 856f01b
Delete more tenant references. Put back ten-ant spellings as tenant …
gxglass 3ceaa3c
Put back some tenant stuff into apitester; its deletion seems to have…
gxglass 04a1ef1
Updates to workload files and one other thing based on review comments
gxglass 78e3337
de-actorify decodeKVPairs
gxglass 71d6954
format one source file
gxglass 0cbfaba
Restore transaction tagging doc
gxglass b85e307
Restore throttle doc details in administration.rst
gxglass 1bc255b
Restore fdbserver/workloads/GetEstimatedRangeSize.actor.cpp and assoc…
gxglass 7bffa99
bindings/c/test/{shim related}: update comments and disable functiona…
gxglass 3fc9028
put the cli-throttle tag back in
gxglass 5afa74f
bindingtester: fix python syntax errors
gxglass c852ff8
remove useless comment
gxglass 848d62e
Remove comment about useless comments, and remove the useless comments
gxglass File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this changes bindings. Have you run Joshua binding tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it run under simulation? If so, yes.
However I should probably rerun ctest again as I am not sure when I last ran it on this set of changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking this does not run under simulation (non-C++ languages need multiple processes but that is contrary to the nature of simulation).
Does this stuff get tested by ctest? My recollection from prior PRs that touch non-C++ bindings is that that is usually where they are tested. Anyhow I am running that (or rerunning, I can't remember) now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP