Delete sharded rocks extraneous code (logWriteSize function and its callsites)#12633
Merged
spraza merged 1 commit intoapple:mainfrom Jan 13, 2026
Merged
Delete sharded rocks extraneous code (logWriteSize function and its callsites)#12633spraza merged 1 commit intoapple:mainfrom
spraza merged 1 commit intoapple:mainfrom
Conversation
gxglass
approved these changes
Jan 12, 2026
Contributor
gxglass
left a comment
There was a problem hiding this comment.
thanks for taking care of it.
Contributor
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Contributor
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title. This was added in #12583. I observed it while debugging a separate issue. After talking with Gideon, this code was deemed extraneous, therefore deleting it in this PR.
100K should not be needed but running it just in case: 20260112-231338-praza-shardedrocks-debugcod-0089376612d67eb9 compressed=True data_size=34487960 fail_fast=10 max_runs=100000 priority=100 sanity=False submitted=20260112-231338 timeout=5400 username=praza-shardedrocks-debugcode-99ef7aab415b2f161cc0e3444043f492bedb7b1f.
Will make sure 100K is clean before merging.
100K results: 20260112-231338-praza-shardedrocks-debugcod-0089376612d67eb9 compressed=True data_size=34487960 duration=4364930 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=3:38:59 sanity=False started=100000 stopped=20260113-025237 submitted=20260112-231338 timeout=5400 username=praza-shardedrocks-debugcode-99ef7aab415b2f161cc0e3444043f492bedb7b1f
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)