Skip to content

Delete sharded rocks extraneous code (logWriteSize function and its callsites)#12633

Merged
spraza merged 1 commit intoapple:mainfrom
spraza:shardedrocks-debugcode
Jan 13, 2026
Merged

Delete sharded rocks extraneous code (logWriteSize function and its callsites)#12633
spraza merged 1 commit intoapple:mainfrom
spraza:shardedrocks-debugcode

Conversation

@spraza
Copy link
Collaborator

@spraza spraza commented Jan 12, 2026

As title. This was added in #12583. I observed it while debugging a separate issue. After talking with Gideon, this code was deemed extraneous, therefore deleting it in this PR.

100K should not be needed but running it just in case: 20260112-231338-praza-shardedrocks-debugcod-0089376612d67eb9 compressed=True data_size=34487960 fail_fast=10 max_runs=100000 priority=100 sanity=False submitted=20260112-231338 timeout=5400 username=praza-shardedrocks-debugcode-99ef7aab415b2f161cc0e3444043f492bedb7b1f.

Will make sure 100K is clean before merging.


100K results: 20260112-231338-praza-shardedrocks-debugcod-0089376612d67eb9 compressed=True data_size=34487960 duration=4364930 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=3:38:59 sanity=False started=100000 stopped=20260113-025237 submitted=20260112-231338 timeout=5400 username=praza-shardedrocks-debugcode-99ef7aab415b2f161cc0e3444043f492bedb7b1f

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@spraza spraza requested a review from gxglass January 12, 2026 23:18
Copy link
Contributor

@gxglass gxglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of it.

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: 99ef7aa
  • Duration 0:23:18
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 99ef7aa
  • Duration 0:33:38
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 99ef7aa
  • Duration 0:44:57
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 99ef7aa
  • Duration 0:51:27
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 99ef7aa
  • Duration 1:00:39
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 99ef7aa
  • Duration 1:03:44
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 99ef7aa
  • Duration 1:52:03
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@spraza spraza merged commit ba1d659 into apple:main Jan 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants