Conversation
…eived full metrics
…l comment saying that this seems testable outside simulation
…st. Have not tried to compile this yet.
…usly deleted files, so delete them again
…ed. Still doesnt compile but getting closer.
…n at rest. NOT TESTED.
…; restarting tests using <= 7.4 binaries do need encryptModes to say disabled
…lutions are more clear and generally better
…I see no need to support it as it requires unneeded interfaces and test fixtures in order to actually work.
…pe 3 (redwood) on upgrade tests, as it writes databases with encoding type 1 which is no longer supported
… metadata, and explain why we are merely renaming the member as deprecated and nothing anything else.
…ses with "0xFF XOR encryption" style encoding (encoding 1), which is removed in main.
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Result of foundationdb-pr on Linux RHEL 9
|
Result of foundationdb-pr-clang on Linux RHEL 9
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
@akankshamahajan15 addressed in followup commit. Compiled but not tested (will let CI do its thing). |
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
fdbbackup/backup.actor.cpp
Outdated
There was a problem hiding this comment.
This can also be removed
|
@gxglass There are few places with encryptionEnabled code in backup.actor.cpp like: |
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr on Linux RHEL 9
|
Result of foundationdb-pr-clang on Linux RHEL 9
|
Thanks. Should this stuff also be removed? That said, intuition is telling me that this is needed for file-level encryption: Can you confirm? |
|
|
@gxglass Code says: It's not super clear and bit confusing. From the code it looks like related to encryption at rest for backups. |
That's what it looks like to me, and I think that usage blurb confirms it. I will remove this. |
CI failure looks like rdar://168252045 |
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux RHEL 9
|
Result of foundationdb-pr on Linux RHEL 9
|
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
PR apple#12667 has removed this feature
…same time. commit c62bb6b Author: gxglass <gxglassgithub@gmail.com> Date: Wed Feb 4 16:02:06 2026 -0800 Delete encryption at rest (apple#12667)
Delete encryption at rest in accordance with plans circulated in PR #12400.
Development of this PR was mostly straightforward. Several issues of note:
Upgrade tests which use Redwood want to use the old "encrypt by 0xFF XOR" test-only encoding/encryption algorithm. I wanted to delete that in main and did so. Upgrade tests have been modified not to use Redwood (storage engine 3, mentioned in various
storageEngineExcludeTypestest options updates). 7.1 did not definestorageEngineExcludeTypes. After some discussion we have decided to delete 7.1-based upgrade tests. 7.3- and 7.4-based upgrade tests remain in place.Cross-version compatibility (such as it is, I assume in client library startup) remains super easy to break when deleting code. Tips: (A) removing unnecessary arguments to functions is bread and butter code editing when removing code, but if you find yourself removing arguments from a serializer() invocation, you might be breaking a protocol. (B) run ctest -R upgrade early and often.
An implication of these changes is that we are going to rely on the community to make us aware of any {upgrade+Redwood}-specific bugs. In other words, we are declining to continue to go out of our way to test functionality that we have no plans to use.
On the plus side this reclaims 15,000 more lines of code that we don't have to look at or think about, including in common areas such as commit proxy, backups, and generic storage server code.
Testing:
20260129-230241-gglass-15694f5f80af6932 compressed=True data_size=34905446 duration=4335357 ended=100000 fail_fast=1000 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=6:21:47 sanity=False started=100000 stopped=20260130-052428 submitted=20260129-230241 timeout=5400 username=gglass
20260202-214159-gglass-69b90c779cf8ec68 compressed=True data_size=35007141 duration=4612639 ended=100000 fail_fast=1000 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=3:00:25 sanity=False started=100000 stopped=20260203-004224 submitted=20260202-214159 timeout=5400 username=gglass