Skip to content

feat: Configurable init container images #32845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kvandenhoute wants to merge 1 commit into
base: release
Choose a base branch
from
Open

feat: Configurable init container images #32845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions deploy/helm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,14 @@ The command uninstalls the release and removes all Kubernetes resources associat
| `image.repository` | Appsmith image repository | `appsmith/appsmith-ce` |
| `image.tag` | Appsmith image tag | `latest` |
| `image.pullPolicy` | Appsmith image pull policy | `IfNotPresent` |
| `initContainer.redis.registry` | Redis image registry | `docker.io` |
| `initContainer.redis.repository` | Redis image repository | `bitnami/redis-cluster` |
| `initContainer.redis.tag` | Redis image tag | `7.0.13-debian-11-r10` |
| `initContainer.redis.pullPolicy` | Redis image pull policy | `IfNotPresent` |
| `initContainer.mongodb.registry` | Mongodb image registry | `docker.io` |
| `initContainer.mongodb.repository` | Mongodb image repository | `bitnami/mongodb` |
| `initContainer.mongodb.tag` | Mongodb image tag | `5.0.21-debian-11-r5` |
| `initContainer.mongodb.pullPolicy` | Mongodb image pull policy | `IfNotPresent` |

### Appsmith deployment parameters
| Name | Description | Value |
Expand Down
6 changes: 4 additions & 2 deletions deploy/helm/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,18 +49,20 @@ spec:
{{- if ((.Values.initContainer.redis).image) }}
image: {{ .Values.initContainer.redis.image }}
{{- else }}
image: "docker.io/bitnami/redis:7.0.13-debian-11-r10"
image: {{ .Values.initContainer.redis.registry }}/{{ .Values.initContainer.redis.repository }}:{{ .Values.initContainer.redis.tag }}
{{- end }}
command: ['sh', '-c', "until redis-cli -h {{.Release.Name}}-redis-master.{{.Release.Namespace}}.svc.cluster.local ping ; do echo waiting for redis; sleep 2; done"]
imagePullPolicy: {{ .Values.initContainer.redis.pullPolicy }}
{{- end }}
{{- if .Values.mongodb.enabled }}
- name: mongo-init-container
{{- if ((.Values.initContainer.mongodb).image) }}
image: {{ .Values.initContainer.mongodb.image }}
{{- else }}
image: "docker.io/bitnami/mongodb:5.0.21-debian-11-r5"
image: {{ .Values.initContainer.mongodb.registry }}/{{ .Values.initContainer.mongodb.repository }}:{{ .Values.initContainer.mongodb.tag }}
{{- end }}
command: ['sh', '-c', "until mongo --host appsmith-mongodb.{{.Release.Namespace}}.svc.cluster.local --eval 'db.runCommand({ping:1})' ; do echo waiting for mongo; sleep 2; done"]
imagePullPolicy: {{ .Values.initContainer.mongodb.pullPolicy }}
{{- end }}
containers:
- name: {{ .Values.containerName }}
Expand Down
16 changes: 11 additions & 5 deletions deploy/helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,17 @@ strategyType: RollingUpdate
##
## Init containers for redis & mongodb
##
initContainer: {}
# redis:
# image: docker.io/bitnami/redis-cluster:7.0.13-debian-11-r10
# mongodb:
# image: docker.io/bitnami/mongodb:5.0.21-debian-11-r5
initContainer:
redis:
registry: docker.io
repository: bitnami/redis-cluster
tag: 7.0.13-debian-11-r10
pullPolicy: IfNotPresent
mongodb:
registry: docker.io
repository: bitnami/mongodb
tag: 5.0.21-debian-11-r5
pullPolicy: IfNotPresent
## Image
##
image:
Expand Down