-
Notifications
You must be signed in to change notification settings - Fork 3
add Nextcloud to Application Deployment Demos #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/modules/ROOT/pages/tutorials/demo-app/appcat-nextcloud.adoc
Outdated
Show resolved
Hide resolved
simu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall (I've noted it a couple times inline already): Please keep the documentation sources to one sentence per line. This makes reviewing and making review suggestions much easier (suggestions are easier to write & read with one sentence per line).
Also, IMO documenting AppFlow in the APPUiO end user docs doesn't make sense currently since an APPUiO user which created her account using a social login (GitHub) through the self-signup flow won't even have access to control.vshn.net.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether this is a good fit for the APPUiO end user docs (since APPUiO as a product encourages self-service via K8s API). Currently, users who signed up for APPUiO via social login / self sign-up don't even have access to control.vshn.net.
IMO this would make more sense somewhere in the VSHN AppFlow user documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See other comment. For users with AppFlow it is way more convenient. Customers who don't have access to AppFlow see the feature and might want to buy it. We will keep the AppFlow docs here.
docs/modules/ROOT/pages/tutorials/demo-app/appcat-nextcloud.adoc
Outdated
Show resolved
Hide resolved
|
|
||
| == Add the https://products.vshn.ch/appcat/index.html[VSHN Application Catalog] claim | ||
|
|
||
| To provision Nextcloud, we need a https://products.vshn.ch/appcat/nextcloud.html[VSHNNextcloud] claim. The documentation for VSHNNextcloud can be found here: https://docs.appcat.ch/vshn-managed/nextcloud/index.html[Nextcloud by VSHN]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the docs at one sentence per line. That makes reviewing (in particular when making suggestions or reviewing changes later on) much easier. Antora/Asciidoc will only insert paragraph breaks for empty lines.
Nicer formatting for the 2nd sentence might be:
| To provision Nextcloud, we need a https://products.vshn.ch/appcat/nextcloud.html[VSHNNextcloud] claim. The documentation for VSHNNextcloud can be found here: https://docs.appcat.ch/vshn-managed/nextcloud/index.html[Nextcloud by VSHN]. | |
| To provision Nextcloud, we need a https://products.vshn.ch/appcat/nextcloud.html[VSHNNextcloud] claim. | |
| The documentation for VSHNNextcloud can be found at https://docs.appcat.ch/vshn-managed/nextcloud/index.html[Nextcloud by VSHN]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| If you are a VSHN customer, you can generate the pipeline to deploy Nextcloud in | ||
| xref:#appflow-helm[AppFlow]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please keep the sources at one sentence per line.
| If you are a VSHN customer, you can generate the pipeline to deploy Nextcloud in | |
| xref:#appflow-helm[AppFlow]. | |
| If you are a VSHN customer, you can generate the pipeline to deploy Nextcloud in xref:#appflow-helm[AppFlow]. |
| For the pipeline to work, you need to add a kubeconfig to your pipeline. | ||
| First, you need to make sure you have the `oc` utility. You can download it from | ||
| the https://console.cloudscale-lpg-2.appuio.cloud/command-line-tools[OpenShift console command line tools]. | ||
| Then you can show the command to create your kubeconfig in the https://oauth-openshift.apps.cloudscale-lpg-2.appuio.cloud/oauth/token/display?code=sha256~xhC3o8qafyrrISMXZhKRt9uhIf-687n7LCHL6jpYl5k&state=[OpenShift console]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is probably your token :) -- should be expired by now I assume.
You want the following link here: https://oauth-openshift.apps.cloudscale-lpg-2.appuio.cloud/oauth/token/request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uupsi, thank you.
The token is as get parameter in there and not determined via the authentication.
I rotated the token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced with web login
| adapt it where needed. | ||
| For the pipeline to work, you need to add a kubeconfig to your pipeline. | ||
| First, you need to make sure you have the `oc` utility. You can download it from | ||
| the https://console.cloudscale-lpg-2.appuio.cloud/command-line-tools[OpenShift console command line tools]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it makes sense to link to a particular APPUiO zone here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have an APPUiO Account you have access to both clusters, not?
What would be your suggestion?
| [source,shell] | ||
| ---- | ||
| KUBECONFIG=./config-for-pipeline | ||
| oc login ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just oc login --web --server https://api.<zone>.appuio.cloud:6443? That should pop up a login screen or immediately fetch a token via local browser integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as info: Here is another way documented: https://portal.appuio.cloud/kubeconfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BacLuc The linked docs are about connecting to the APPUiO control API (which is also just a kubernetes API). Not to an actual APPUiO cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as info: Here is another way documented: https://portal.appuio.cloud/kubeconfig
That has nothing to do with accessing a zone, that's for accessing the APPUiO Control API directly via kubectl instead of via portal.appuio.cloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced with oc login --web
|
|
||
| To keep track of what's deployed, we put this claim into our Git repository. | ||
| For that, you need to create a https://github.com/new[new Git repository] on GitHub. | ||
| Now, we store the claim from before under `helm/templates/nextcloud.yaml`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does https://docs.appcat.ch/references/argocd.html also apply if the claim is wrapped in a helm chart? Never tested that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We let helm try to delete the resources in the deployments we did until now.
The helm uninstall fails in this case because of the deletion protection.
If you want to uninstall a helm chart with appcat claims you must disable the deletion protection before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then the app remains in an unsynced state? Because it tries to delete the claim but can't? It also sounds a bit dangerous having it hang in limbo the whole time.
docs/modules/ROOT/pages/tutorials/demo-app/appcat-nextcloud.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If something in the UI changes this is outdated.
I would explain the necessary configuration options along with sensible default values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhat the same nitpick as with the other UI screenshot.
Although a good description would be preferred, in this case I would at least only select the relevant part of the page so it's better legible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| @@ -0,0 +1,14 @@ | |||
| [#appflow-helm] | |||
| == Create application and environment with link:++https://www.vshn.ch/en/solutions/appflow/[Appflow]++[AppFlow] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until we found a sensible location for the AppFlow User documentation I guess it's acceptable to leave this here.
@martini-source and me decided that we will keep the small hint for AppFlow here. |
c2296b2 to
3e63468
Compare
3e63468 to
1a884ad
Compare
|
@simu |
|
Sorry for all the trouble. There was too much resistance against putting AppFlow into the APPUiO docs. |
At Nunki we have some requests where people would like to deploy AppCat services to APPUiO.
Maybe these docs are well enough that they can do it by themselves.
Checklist
Categorize the PR by setting a good title and adding one of the labels:
how-to,tutorial,reference,explanation,cicd,dependencyas they show up in the changelog
I cannot set a label.
Link this PR to related issues if applicable.No issue available.