Fix Android OAuth2 page not being resumed properly#1263
Open
Namaneo wants to merge 1 commit intoappwrite:masterfrom
Open
Fix Android OAuth2 page not being resumed properly#1263Namaneo wants to merge 1 commit intoappwrite:masterfrom
Namaneo wants to merge 1 commit intoappwrite:masterfrom
Conversation
Removed the 'intentFlags' parameter from FlutterWebAuth2Options.
Contributor
WalkthroughThe change removes an explicit Estimated Code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the 'intentFlags' parameter from FlutterWebAuth2Options.
What does this PR do?
There's currently an issue on Android where, after opening an Auth Tab and switching apps, the authentication page is killed instead of being resumed. This breaks the authentication flow when say a 2FA code is required. This PR fixes this issue, and make the authentication page resume correctly after switching apps or going back to the app from the home screen.
To add more details, Appwrite Flutter SDK now uses
flutter_web_auth_2version 5.0.0 alpha. In recent releases,ephemeralIntentFlagshas been deprecated in favor ofpreferEphemeral, which isn't required here since it has been there for a while for iOS, and would make the Auth Tab use a private session without existing logged in accounts.Test Plan
Manual.
Related PRs and Issues
Fixes appwrite/sdk-for-flutter#181.
Have you read the Contributing Guidelines on issues?
Yes.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.