-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Improve speed of chunky dealing and serialization #18611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
rex1fernando
approved these changes
Feb 9, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
✅ Forge suite
|
Contributor
✅ Forge suite
|
Contributor
✅ Forge suite
|
ibalajiarun
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
arkworks::batch_mul()that avoids premature normalizationchunkydealingbatch_normalize)CodomainNormalizedassociated type andnormalize()method tohomomorphism::Traitbatch_normalize()method tofixed_base_msms::Traitchunkyandchunky_v2'sSubtranscriptsince they are identicalFirstProofItemandProoffromsigma_protocol/traits.rsinto a separate filePublicParametersinchunked_elgamal_pp.rsto useArc<BatchMulPreprocessing<C>>rather thanOption<BatchMulPreprocessing<C>>; this fixes potential issues with e.g. cloning such public parameters.decrypt-sharebench, to ensure the weights are nonzerochunkyandchunky_v2almost entirely affine (rather than projective)jolt-core)Benchmarks show that:
How Has This Been Tested?
Key Areas to Review
I'm not too familiar with the
fptxanddkgcode, I hope the changes there are correct.Type of Change
Which Components or Systems Does This Change Impact?
dkgpartChecklist
Note
Medium Risk
Touches cryptographic proof/commitment and PVSS transcript code paths (normalization, serialization, aggregation, and Zeromorph verification), where subtle mistakes can break correctness or soundness despite being performance-motivated.
Overview
Improves performance of PVSS chunky dealing and transcript handling by introducing a custom
arkworks::batch_mul()that avoids early batch normalization, precomputing/reusingBatchMulPreprocessingtables (nowArc-backed), and moving transcript fields largely to affine representations with explicit projective aggregation + final normalization.Refactors the sigma protocol/homomorphism stack to distinguish projective vs canonical forms via
CodomainNormalizedandnormalize(), addsbatch_normalize()tofixed_base_msms::Trait, updates Fiat–Shamir and verification paths to operate on normalized statements/commitments, and extractsProof/FirstProofIteminto a dedicated module.Fixes correctness/ergonomics issues around aggregation and verification: SCRAPE LDT now consumes affine bases (removing redundant normalization), the
decrypt-sharebench avoids zero-weight/invalid players, weighted transcript aggregation uses projective accumulation then normalizes, and Zeromorph is corrected to align variable ordering/blinding and now has a full test suite (ported fromjolt-core).Written by Cursor Bugbot for commit 6697cea. This will update automatically on new commits. Configure here.