[execution] Add global context placeholder with guards #18639
+305
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
georgemitenkov
requested review from
calintat,
vgao1996,
vineethk,
wrwg and
zekun000
georgemitenkov
force-pushed
the
george/global-context
branch
from
20ceaa0 to
39560a2
Compare
georgemitenkov
force-pushed
the
george/global-context
branch
from
39560a2 to
e753a18
Compare
22 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| .map(|_| { | ||
| let ctx = Arc::clone(&ctx); | ||
| thread::spawn(move || { | ||
| let _guard = ctx.execution_context(); |
There was a problem hiding this comment.
Simulation test silently ignores failed lock acquisitions
Medium Severity
In test_block_execution_simulation, both execution_context() and maintenance_context() return Option values that are silently assigned without .expect() or any assertion. If lock acquisition fails (returns None), the test passes without actually holding any guard, defeating the purpose. Every other test in this file uses .expect() to verify successful acquisition.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Global context template for execution, as described in design doc but simpler. Instead of atomics, implemented via
RwLockso no unsafe is needed. On execution (block), read-lock is acquired. For maintenance (between blocks), write-lock is acquired. Added a few tests for that. Note:Contextwill be populated with data and caches, with unsafe APIs which are safe through execution or maintenance guard implementations.How Has This Been Tested?
Unit tests added.
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist
Note
Medium Risk
Introduces new cross-thread synchronization primitives and timing-based concurrency tests; while currently a placeholder, future consumers may rely on the lock semantics and could hit contention/starvation issues if misused.
Overview
Adds a new
global-contextMonoMove crate that introduces aGlobalContextwith a two-phase locking API: non-blocking acquisition of sharedExecutionContextread guards for parallel execution, and exclusiveMaintenanceContextwrite guards for between-block maintenance.Wires the crate into the workspace (
Cargo.tomlandCargo.lock) and adds integration tests validating concurrent execution access and mutual exclusion between execution and maintenance phases.Written by Cursor Bugbot for commit e753a18. This will update automatically on new commits. Configure here.