fix: set numpy and deepspeed dependency versions #503
Open
etowahadams wants to merge 1 commit intoaqlaboratory:pl_upgradesfrom
Open
fix: set numpy and deepspeed dependency versions #503etowahadams wants to merge 1 commit intoaqlaboratory:pl_upgradesfrom
etowahadams wants to merge 1 commit intoaqlaboratory:pl_upgradesfrom
Conversation
etowahadams
commented
Nov 13, 2024
| - pytorch-lightning | ||
| - biopython | ||
| - numpy | ||
| - numpy==1.26.4 |
Contributor
Author
There was a problem hiding this comment.
Currently, numpy is unversioned, causing numpy 2.0+ to be installed which leads to failing tests
etowahadams
commented
Nov 13, 2024
| - pytorch::pytorch-cuda=12.1 | ||
| - pip: | ||
| - deepspeed==0.12.4 | ||
| - deepspeed==0.14.5 |
Contributor
Author
There was a problem hiding this comment.
Old version causes a module 'deepspeed' has no attribute 'comm' error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version of deepspeed specified in environment.yml will lead to a
module 'deepspeed' has no attribute 'comm'error, so we need to upgrade it. The latest numpy version will lead toCould not infer dtype of numpy.int32error, so I downgraded it. This lets all of the tests pass