feat(plugin): implement WASM module instance pooling#10136
Draft
ankit98040 wants to merge 5 commits intoaquasecurity:mainfrom
Draft
feat(plugin): implement WASM module instance pooling#10136ankit98040 wants to merge 5 commits intoaquasecurity:mainfrom
ankit98040 wants to merge 5 commits intoaquasecurity:mainfrom
Conversation
c1ec554 to
7a57e05
Compare
Contributor
|
Hi @ankit98040 ! It looks like you have another identical PR open. Could you close one of them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements module instance pooling for WASM modules. Previously, WASM module analysis was serialized using a mutex because
wazeromodule instances are not thread-safe. This change introduces async.Poolto manage a pool ofwasmInstances, allowing concurrent execution ofAnalyzeandPostScanmethods. This directly addresses the TODO comment inpkg/module/module.goregarding performance improvements to "improve the Analyze performance by having module instance pool".Key changes:
wasmModuleto be a manager that holds async.Poolof instances.wasmInstancestruct to hold stateful module data (api.Module,memFS, exported functions).AnalyzeandPostScanto lease instances from the pool for the effective duration of the call.Closeto properly close thewazero.Runtimeand cleanup resources.Related issues
Related PRs
Checklist