Feature: allow queue callback function parameter#519
Feature: allow queue callback function parameter#519reabreu wants to merge 1 commit intoarchiverjs:masterfrom
Conversation
|
Any word on this being merged? |
|
Hey, no word yet. |
manglass
left a comment
manglass
left a comment
There was a problem hiding this comment.
Pending these points, I think this is an excellent addition to the library.
I will check-in with @ctalkington to see if a maintainer is available to accept the final 2 points.
[ ] Update README.md (see direct comment)
[ ] maintainer approves/denies chai-spies
[ ] maintainer approves/denies addition of yarn.lock
|
|
||
| // append a file with a callback for when the queue has been processed. | ||
| // usefull for implementing backpressure prevention mechanisms | ||
| archive.file("file1.txt", { name: "file4.txt" }, () => { |
There was a problem hiding this comment.
[✓] creating this documentation is an excellent touch
[ ] it should be moved from the archive.file example to the archive.append example(s)
| "devDependencies": { | ||
| "archiver-jsdoc-theme": "^1.1.3", | ||
| "chai": "^4.2.0", | ||
| "chai-spies": "^1.0.0", |
There was a problem hiding this comment.
[✓] I successfully ran the tests locally with this helper
[ ] It is up to the maintainer if they want to add a new library, or if they have other techniques for this type of test...
3 participants
Hello and thanks for your work!
I've added an optional callback parameter to the append function cause we needed it to handle backpressure on an intense export feature we're developing.
Please have a look and let me know if we can add it to the library.