Created KeyboardandMousecontrol.ino#32
Created KeyboardandMousecontrol.ino#32Arsh0508 wants to merge 5 commits intoarduino-libraries:masterfrom
Conversation
per1234
left a comment
There was a problem hiding this comment.
Please spell the sketch name the same as in the existing example sketch: KeyboardAndMouseControl
|
As I brought up in arduino-libraries/Mouse#13 (comment): One thing to note is that this example already comes bundled with the Arduino IDE (and Arduino Web Editor) under File > Examples > 09.USB > KeyboardAndMouseControl. It does make sense to bundle the examples with the library since the IDE bundled examples are not available to arduino-cli and Arduino Pro IDE users. I don't like the idea of having duplicate code to maintain, but it also could be problematic to remove the built-in sketches since there are likely tutorials that point people to that menu path. I suppose we could replace the content of the built in sketches with a comment like: // This example has been moved to File > Examples > Keyboard > KeyboardLogout(should be adapted to make sense for Arduino Web Editor users also) |
per1234
left a comment
There was a problem hiding this comment.
I recommend also adding the layout and schematic files from https://github.com/arduino/Arduino/tree/master/build/shared/examples/09.USB/KeyboardAndMouseControl
|
@per1234 thank you so much for your valuable suggestions sir, will get right onto it and make the needful changes. |
Co-Authored-By: per1234 <accounts@perglass.com>
|
@per1234 I've done the requested changes and would be grateful if you can review them. |
| /* | ||
| This example has been moved to File > Examples > USB > KeyboardAndMouseControl | ||
| https://github.com/arduino/Arduino/tree/master/build/shared/examples/09.USB/KeyboardAndMouseControl | ||
| */ | ||
|
|
||
| /* | ||
| KeyboardAndMouseControl | ||
|
|
There was a problem hiding this comment.
| /* | |
| This example has been moved to File > Examples > USB > KeyboardAndMouseControl | |
| https://github.com/arduino/Arduino/tree/master/build/shared/examples/09.USB/KeyboardAndMouseControl | |
| */ | |
| /* | |
| KeyboardAndMouseControl |
This makes no sense. The example has not been moved to File > Examples > USB > KeyboardAndMouseControl. The example has always been there. The whole point of your pull request is to move (or copy) that sketch FROM File > Examples > USB > KeyboardAndMouseControl TO File > Examples > Mouse > KeyboardAndMouseControl.
There is no benefit to providing a link to the copy of the sketch in the arduino/Arduino repository. If they saw that comment, the user is already looking at the sketch.
|
|
This code would be really helpful for new users and so it'll be great if this code is present in the library itself