Using the endpoint parameter in Whisperkit and downloading CoreML and tokenizer#396
Open
lemo366 wants to merge 3 commits intoargmaxinc:release/v0.14.1from
Open
Using the endpoint parameter in Whisperkit and downloading CoreML and tokenizer#396lemo366 wants to merge 3 commits intoargmaxinc:release/v0.14.1from
lemo366 wants to merge 3 commits intoargmaxinc:release/v0.14.1from
Conversation
Contributor
|
Thanks @lemo366 this looks great! Do the unit tests pass with hf-mirror as the default? Might be worth including at least one test that uses hf-mirror as the endpoint for a simple download. |
Co-authored-by: Zach Nagengast <zacharynagengast@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to specify the
endpointvia parameters when initializing WhisperKit, thus enabling the download of CoreML models and tokenizers from domestic mirror sites (such as hf-mirror.com).