fix: FROM path in Dockerfile recommendation#662
Open
jbouter wants to merge 2 commits intoargoproj-labs:mainfrom
Open
fix: FROM path in Dockerfile recommendation#662jbouter wants to merge 2 commits intoargoproj-labs:mainfrom
jbouter wants to merge 2 commits intoargoproj-labs:mainfrom
Conversation
Pulling from `argoproj/argocd:latest` uses the preferred registry from the user. If this is dockerhub, it will pull a very outdated image of argocd. Signed-off-by: Jeffrey Bouter <jeffrey@kn0x.org>
pre
approved these changes
Sep 25, 2024
werne2j
approved these changes
Sep 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
==========================================
+ Coverage 72.16% 73.55% +1.38%
==========================================
Files 26 26
Lines 1994 1588 -406
==========================================
- Hits 1439 1168 -271
+ Misses 458 315 -143
- Partials 97 105 +8 ☔ View full report in Codecov by Sentry. |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulling from
argoproj/argocd:latestuses the preferred registry from the user. If this is dockerhub, it will pull a very outdated image of argocd.Description
The docs recommend using a FROM that can possibly be broken
Fixes: <! -- link to issue -->
Checklist
Please make sure that your PR fulfills the following requirements:
go mod tidy -compat=1.21to ensure only the minimum is pulled in.Type of Change
Other information