feat(azure-china): support azure china vault backend endpoint#673
Open
harshktpa wants to merge 1 commit intoargoproj-labs:mainfrom
Open
feat(azure-china): support azure china vault backend endpoint#673harshktpa wants to merge 1 commit intoargoproj-labs:mainfrom
harshktpa wants to merge 1 commit intoargoproj-labs:mainfrom
Conversation
harshktpa
force-pushed
the
az-vault-cn
branch
from
04d2b72 to
9c356ad
Compare
Signed-off-by: hkatepa1 <hkatepa1@ford.com>
harshktpa
force-pushed
the
az-vault-cn
branch
from
9c356ad to
6d26cd3
Compare
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces modifications to the Azure Key Vault backend to support Azure China. It enhances the GetSecrets and GetIndividualSecret methods to dynamically adjust the vault URL based on the environment specified in the AVP_AZ_CLOUD_NAME environment variable.
Fixes: #672 (support azure china cloud vault backend endpoint)
Checklist
Please make sure that your PR fulfills the following requirements:
go mod tidy -compat=1.22.7to ensure only the minimum is pulled in.Type of Change
Other information
Other information
These changes allow the Azure Key Vault backend to function correctly in both standard Azure and Azure China environments by using the AVP_AZ_CLOUD_NAME environment variable. The logic for constructing the vault URL is updated, and the methods now handle secret retrieval based on the specified azure cloud environment.