Skip to content

feat(argo-rollouts): Restrict write access to rollout status in the aggregated roles #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nedal87 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(argo-rollouts): Restrict write access to rollout status in the aggregated roles #2536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/argo-rollouts/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v2
appVersion: v1.6.4
appVersion: v1.6.6
description: A Helm chart for Argo Rollouts
name: argo-rollouts
version: 2.34.0
version: 2.35.0
home: https://github.com/argoproj/argo-helm
icon: https://argoproj.github.io/argo-rollouts/assets/logo.png
keywords:
Expand All @@ -19,4 +19,4 @@ annotations:
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: changed
description: Allow setting log config for rollouts dashboard
description: Restrict rollout status write access in the aggregated roles
1 change: 0 additions & 1 deletion charts/argo-rollouts/templates/aggregate-roles.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ rules:
resources:
- rollouts
- rollouts/scale
- rollouts/status
Copy link
Collaborator

@yu-croco yu-croco Feb 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR.
Since upstream has the permission in latest version, so can you please fix upstream at first ?
*argo-helm follows upstream's manifest.
https://github.com/argoproj/argo-rollouts/blob/v1.6.6/manifests/base/argo-rollouts-aggregate-roles.yaml

Copy link
Author

@nedal87 nedal87 Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yu-croco sure thing, I will open a PR in upstream. Thanks!

- experiments
- analysistemplates
- clusteranalysistemplates
Expand Down