fix: route klog output through configured logger to respect JSON log format #15528
+179
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…format klog (used by client-go informers/reflectors) was outputting in text format because the klog-to-logging adapter was only set up lazily when the first event recorder was created. This moves the adapter to util/logging and calls SetupKlogAdapter early in all entrypoints, ensuring klog output respects --log-format json from startup. Fixes argoproj#14841 (remaining pod informer logging) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Sebastian Büchler <42775578+sebastianbuechler@users.noreply.github.com>
sebastianbuechler
force-pushed
the
fix/klog-json-log-format
branch
from
d78e60f to
0a24f58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
logrSink) fromworkflow/events/toutil/logging/klog.goand exported it asSetupKlogAdapterSetupKlogAdapterearly in all three entrypoints (workflow-controller, argoexec, argo CLI) immediately after logger creation, before any client-go informers startworkflow/events/event_recorder_logger.gonow delegates to the shared implementationRoot Cause
klog(used internally by Kubernetes client-go for informer/reflector logging) was configured to output in text format bySetGLogLevel(). The adapter that redirects klog through Argo's logging system (respecting--log-format json) was only set up lazily insideeventRecorderManager.Get(). All klog output between controller startup and first event recorder creation bypassed the JSON formatter.Related