fix: change RLock to Lock in sync manager methods #15546
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce to prevent concurrent map access The prioritySemaphore.lockHolder map was accessed concurrently without synchronization. Manager.Release, ReleaseAll, and CheckWorkflowExistence used RLock (shared read lock), allowing multiple goroutines to read/write the same prioritySemaphore.lockHolder map simultaneously. Change these methods to use Lock (exclusive write lock) so they are mutually exclusive with each other and with TryAcquire, preventing concurrent map access on prioritySemaphore's internal state. Signed-off-by: Alan Clucas <alan@clucas.org> https://claude.ai/code/session_01AD92yQipDQmgjvxdyveag4
isubasinghe
approved these changes
Feb 11, 2026
Joibel
added
cherry-pick/3.7
|
❌ Cherry-pick failed for 3.7. Please check the workflow logs for details. |
|
🍒 Cherry-pick PR created for 4.0: #15549 |
clintmoyer
pushed a commit
to clintmoyer/argo-workflows
that referenced
this pull request
Feb 11, 2026
Joibel
added a commit
that referenced
this pull request
Feb 11, 2026
…for 4.0) (#15549) Co-authored-by: Alan Clucas <alan@clucas.org>
Joibel
added a commit
that referenced
this pull request
Feb 11, 2026
(cherry picked from commit 2d95ada) Signed-off-by: Alan Clucas <alan@clucas.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15218
Motivation
The
CheckWorkflowExistence,Release, andReleaseAllmethods in the sync manager were using read locks (RLock) when they should be using write locks (Lock). These methods modify the internal state of the sync manager (accessing and potentially modifyingsm.syncLockMap), which requires exclusive write access rather than shared read access.Modifications
Changed the following methods from using
RLock()/RUnlock()toLock()/Unlock():CheckWorkflowExistence()- iterates and modifies sync lock mapRelease()- modifies sync lock map entriesReleaseAll()- modifies sync lock map entriesThis ensures proper synchronization and prevents race conditions when multiple goroutines access these methods concurrently.
Verification
Documentation
No documentation changes needed - this is an internal synchronization fix.
AI
Co-authored with Claude